Merge pull request #3961 from matrix-org/travis/legacy-decorators

Switch back to legacy decorators
This commit is contained in:
Travis Ralston 2020-01-28 16:54:13 +00:00 committed by GitHub
commit dc1405c3b3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 7 deletions

View file

@ -11,7 +11,7 @@ module.exports = {
"@babel/preset-react" "@babel/preset-react"
], ],
"plugins": [ "plugins": [
["@babel/plugin-proposal-decorators", {decoratorsBeforeExport: true}], ["@babel/plugin-proposal-decorators", {legacy: true}],
"@babel/plugin-proposal-export-default-from", "@babel/plugin-proposal-export-default-from",
"@babel/plugin-proposal-numeric-separator", "@babel/plugin-proposal-numeric-separator",
"@babel/plugin-proposal-class-properties", "@babel/plugin-proposal-class-properties",

View file

@ -32,13 +32,9 @@ import * as sdk from '../index';
* with a skinned version. If no skinned version is available, this component * with a skinned version. If no skinned version is available, this component
* will be used. * will be used.
*/ */
export function replaceableComponent<T extends{new(...args: any[])}>(name: string) { export function replaceableComponent(name: string, origComponent: React.Component) {
// Decorators return a function to override the class (origComponent). This // Decorators return a function to override the class (origComponent). This
// ultimately assumes that `getComponent()` won't throw an error and instead // ultimately assumes that `getComponent()` won't throw an error and instead
// return a falsey value like `null` when the skin doesn't have a component. // return a falsey value like `null` when the skin doesn't have a component.
return (origComponent) => { return () => sdk.getComponent(name) || origComponent;
const c = sdk.getComponent(name) || origComponent;
c.kind = "class"; // appeases babel
return c;
};
} }