apply pr review feedback

fix copyright headers
fix user settings link accessibility
fix typo and add noopener

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
This commit is contained in:
Michael Telatynski 2018-06-13 18:46:02 +01:00
parent 18546dbe06
commit d4578783ef
No known key found for this signature in database
GPG key ID: 3F879DA5AD802A5E
3 changed files with 8 additions and 7 deletions

View file

@ -1,6 +1,6 @@
/*
Copyright 2015, 2016 OpenMarket Ltd
Copyright 2018 Vector Creations Ltd
Copyright 2018 New Vector Ltd
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.

View file

@ -1304,9 +1304,9 @@ module.exports = React.createClass({
<div className="mx_UserSettings_section">
<div className="mx_UserSettings_advanced">
{ _t("Logged in as:") + ' ' }
<span onClick={this.onSelfShareClick} className="mx_UserSettings_link">
<a onClick={this.onSelfShareClick} className="mx_UserSettings_link">
{ this._me }
</span>
</a>
</div>
<div className="mx_UserSettings_advanced">
{ _t('Access Token:') + ' ' }

View file

@ -1,5 +1,5 @@
/*
Copyright 2018 Vector Creations Ltd
Copyright 2018 New Vector Ltd
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
@ -37,7 +37,7 @@ const socials = [
img: 'img/social/',
url: (url) => `https://plus.google.com/share?url=${url}`,
},*/ {
name: 'Linked In',
name: 'LinkedIn',
img: 'img/social/linkedin.png',
url: (url) => `https://www.linkedin.com/shareArticle?mini=true&url=${url}`,
}, {
@ -193,13 +193,14 @@ export default class ShareDialog extends React.Component {
<h3>Social</h3>
<div className="mx_ShareDialog_social_container">
{
socials.map((social) => <a target="_blank"
socials.map((social) => <a rel="noopener"
target="_blank"
key={social.name}
name={social.name}
href={social.url(encodedUrl)}
className="mx_ShareDialog_social_icon"
>
<img src={social.img} height={64} width={64} />
<img src={social.img} alt={social.name} height={64} width={64} />
</a>)
}
</div>