mirrors/element-web
1
0
Fork 0
mirror of https://github.com/element-hq/element-web synced 2024-10-23 19:25:48 +03:00
Code Issues Projects Releases Packages Wiki Activity

Only emit in RoomViewStore when state actually changes

Browse source 
This adds a shallow state check to attempt to only emit a store update when
something actually changes.

Fixes https://github.com/vector-im/riot-web/issues/12256
This commit is contained in:
J. Ryan Stinnett 2020-02-06 17:57:17 +00:00
parent f89ae19d76
commit c916ef4534
1 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/stores/RoomViewStore.js
View file

@ -66,6 +66,20 @@ class RoomViewStore extends Store {
}
_setState(newState) {
// If values haven't changed, there's nothing to do.
// This only tries a shallow comparison, so unchanged objects will slip
// through, but that's probably okay for now.
let stateChanged = false;
for (const key of Object.keys(newState)) {
if (this._state[key] !== newState[key]) {
stateChanged = true;
break;
}
}
if (!stateChanged) {
return;
}
this._state = Object.assign(this._state, newState);
this.__emitChange();
}