diff --git a/src/components/structures/MessagePanel.tsx b/src/components/structures/MessagePanel.tsx index ff9bc82652..8600da9047 100644 --- a/src/components/structures/MessagePanel.tsx +++ b/src/components/structures/MessagePanel.tsx @@ -452,14 +452,6 @@ export default class MessagePanel extends React.Component { } } - /* check the scroll state and send out pagination requests if necessary. - */ - public checkFillState(): void { - if (this.scrollPanel.current) { - this.scrollPanel.current.checkFillState(); - } - } - private isUnmounting = (): boolean => { return !this.isMounted; }; diff --git a/src/events/EventTileFactory.tsx b/src/events/EventTileFactory.tsx index 7beda8cc30..ecda002f59 100644 --- a/src/events/EventTileFactory.tsx +++ b/src/events/EventTileFactory.tsx @@ -393,6 +393,8 @@ export function haveRendererForEvent(mxEvent: MatrixEvent, showHiddenEvents: boo return hasText(mxEvent, showHiddenEvents); } else if (handler === STATE_EVENT_TILE_TYPES[EventType.RoomCreate]) { return Boolean(mxEvent.getContent()['predecessor']); + } else if (handler === JSONEventFactory) { + return false; } else { return true; } diff --git a/test/components/structures/MessagePanel-test.js b/test/components/structures/MessagePanel-test.js index 3c77429000..eca8c39bec 100644 --- a/test/components/structures/MessagePanel-test.js +++ b/test/components/structures/MessagePanel-test.js @@ -44,6 +44,8 @@ class WrappedMessagePanel extends React.Component { callEventGroupers = new Map(); render() { + const { showHiddenEvents, ...props } = this.props; + const roomContext = { room, roomId: room.roomId, @@ -54,13 +56,14 @@ class WrappedMessagePanel extends React.Component { showJoinLeaves: false, showAvatarChanges: false, showDisplaynameChanges: true, + showHiddenEvents, }; return @@ -633,6 +636,40 @@ describe('MessagePanel', function() { expect(settingsSpy).not.toHaveBeenCalledWith("showHiddenEventsInTimeline"); settingsSpy.mockRestore(); }); + + it("should group hidden event reactions into an event list summary", () => { + const events = [ + TestUtilsMatrix.mkEvent({ + event: true, + type: "m.reaction", + room: "!room:id", + user: "@user:id", + content: {}, + ts: 1, + }), + TestUtilsMatrix.mkEvent({ + event: true, + type: "m.reaction", + room: "!room:id", + user: "@user:id", + content: {}, + ts: 2, + }), + TestUtilsMatrix.mkEvent({ + event: true, + type: "m.reaction", + room: "!room:id", + user: "@user:id", + content: {}, + ts: 3, + }), + ]; + const res = mount(); + + const els = res.find("EventListSummary"); + expect(els.length).toEqual(1); + expect(els.prop("events").length).toEqual(3); + }); }); describe("shouldFormContinuation", () => {