From c5e03913d96e17fbb7fda162d17ebe24af5e6881 Mon Sep 17 00:00:00 2001
From: Richard van der Hoff <richard@matrix.org>
Date: Thu, 10 Mar 2016 10:59:40 +0000
Subject: [PATCH] Factor out audio bings to a separate setting

Some people are sad about bings on the desktop app. Make it turn-off-able.
---
 src/Notifier.js          | 59 ++++++++++++++++++++++++++--------------
 src/UserSettingsStore.js |  8 ++++++
 2 files changed, 46 insertions(+), 21 deletions(-)

diff --git a/src/Notifier.js b/src/Notifier.js
index 1c35bd7509..f0d38bd7b2 100644
--- a/src/Notifier.js
+++ b/src/Notifier.js
@@ -35,7 +35,7 @@ var Notifier = {
         return TextForEvent.textForEvent(ev);
     },
 
-    displayNotification: function(ev, room, actions) {
+    _displayPopupNotification: function(ev, room) {
         if (!global.Notification || global.Notification.permission != 'granted') {
             return;
         }
@@ -84,24 +84,17 @@ var Notifier = {
             global.focus();
         };
 
-        var playAudio = function() {
-            var e = document.getElementById("messageAudio");
-            if (e) {
-                e.load();
-                e.play();
-                return e;
-            }
-        };
-
-        var audioClip;
-        if (actions.tweaks.sound) {
-            audioClip = playAudio();
-        }
-
         global.setTimeout(function() {
             notification.close();
         }, 5 * 1000);
-        
+    },
+
+    _playAudioNotification: function(ev, room) {
+        var e = document.getElementById("messageAudio");
+        if (e) {
+            e.load();
+            e.play();
+        };
     },
 
     start: function() {
@@ -129,6 +122,14 @@ var Notifier = {
     },
 
     setEnabled: function(enable, callback) {
+        // make sure that we persist the current setting audio_enabled setting
+        // before changing anything
+        if (global.localStorage) {
+            if(global.localStorage.getItem('audio_notifications_enabled') == null) {
+                this.setAudioEnabled(this.isEnabled());
+            }
+        }
+
         if(enable) {
             if (!this.havePermission()) {
                 global.Notification.requestPermission(function() {
@@ -174,6 +175,21 @@ var Notifier = {
         return enabled === 'true';
     },
 
+    setAudioEnabled: function(enable) {
+        if (!global.localStorage) return;
+        global.localStorage.setItem('audio_notifications_enabled',
+                                    enable ? 'true' : 'false');
+    },
+
+    isAudioEnabled: function(enable) {
+        if (!global.localStorage) return true;
+        var enabled = global.localStorage.getItem(
+            'audio_notifications_enabled');
+        // default to true if the popups are enabled
+        if (enabled === null) return this.isEnabled();
+        return enabled === 'true';
+    },
+
     setToolbarHidden: function(hidden) {
         this.toolbarHidden = hidden;
         dis.dispatch({
@@ -200,13 +216,14 @@ var Notifier = {
         if (!this.isPrepared) return; // don't alert for any messages initially
         if (ev.sender && ev.sender.userId == MatrixClientPeg.get().credentials.userId) return;
 
-        if (!this.isEnabled()) {
-            return;
-        }
-
         var actions = MatrixClientPeg.get().getPushActionsForEvent(ev);
         if (actions && actions.notify) {
-            this.displayNotification(ev, room, actions);
+            if (this.isEnabled()) {
+                this._displayPopupNotification(ev, room);
+            }
+            if (actions.tweaks.sound && this.isAudioEnabled()) {
+                this._playAudioNotification(ev, room);
+            }
         }
     }
 };
diff --git a/src/UserSettingsStore.js b/src/UserSettingsStore.js
index 45aca1f0dc..49baf3a3a0 100644
--- a/src/UserSettingsStore.js
+++ b/src/UserSettingsStore.js
@@ -58,6 +58,14 @@ module.exports = {
         Notifier.setEnabled(enable);
     },
 
+    getEnableAudioNotifications: function() {
+        return Notifier.isAudioEnabled();
+    },
+
+    setEnableAudioNotifications: function(enable) {
+        Notifier.setAudioEnabled(enable);
+    },
+
     changePassword: function(old_password, new_password) {
         var cli = MatrixClientPeg.get();