fix tbody & keying warnings

This commit is contained in:
Matthew Hodgson 2016-04-17 17:44:04 +01:00
parent 10a053019d
commit aeb438dc62

View file

@ -581,7 +581,7 @@ module.exports = React.createClass({
renderNotifRulesTableRow: function(title, className, pushRuleVectorState) { renderNotifRulesTableRow: function(title, className, pushRuleVectorState) {
return ( return (
<tr key = {className}> <tr key={ className }>
<th> <th>
{title} {title}
</th> </th>
@ -692,17 +692,21 @@ module.exports = React.createClass({
// and this wouldn't be hard to add. // and this wouldn't be hard to add.
var rows = []; var rows = [];
for (var i = 0; i < this.state.pushers.length; ++i) { for (var i = 0; i < this.state.pushers.length; ++i) {
rows.push(<tr> rows.push(<tr key={ i }>
<td>{this.state.pushers[i].app_display_name}</td> <td>{this.state.pushers[i].app_display_name}</td>
<td>{this.state.pushers[i].device_display_name}</td> <td>{this.state.pushers[i].device_display_name}</td>
</tr>); </tr>);
} }
devicesSection = (<table className="mx_UserSettings_devicesTable"> devicesSection = (<table className="mx_UserSettings_devicesTable">
<tr> <thead>
<th>Application</th> <tr>
<th>Device</th> <th>Application</th>
</tr> <th>Device</th>
{rows} </tr>
</thead>
<tbody>
{rows}
</tbody>
</table>); </table>);
} }