Update reasoning around disabling capture_pageview

This commit is contained in:
James Salter 2021-07-21 16:29:11 +01:00
parent 34f8c60b34
commit 93962c0aca

View file

@ -93,9 +93,11 @@ export class PosthogAnalytics {
autocapture: false, autocapture: false,
mask_all_text: true, mask_all_text: true,
mask_all_element_attributes: true, mask_all_element_attributes: true,
// this is disabled for now as its tricky to sanitize properties of the pageview // This only triggers on page load, which for our SPA isn't particularly useful.
// event because sanitization requires async crypto calls and the sanitize_properties // Plus, the .capture call originating from somewhere in posthog makes it hard
// callback is synchronous. // to redact URLs, which requires async code.
//
// To raise this manually, just call .capture("$pageview") or posthog.capture_pageview.
capture_pageview: false, capture_pageview: false,
sanitize_properties: this.sanitizeProperties.bind(this), sanitize_properties: this.sanitizeProperties.bind(this),
respect_dnt: true, respect_dnt: true,