mirrors/element-web
1
0
Fork 0
mirror of https://github.com/element-hq/element-web synced 2024-11-28 20:38:55 +03:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #3051 from matrix-org/travis/bc-sidescroller

Browse source 
Counteract smooth scrolling on breadcrumbs
This commit is contained in:
Travis Ralston 2019-06-03 07:09:36 -06:00 committed by GitHub
commit 8daef3f1e4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/components/structures/IndicatorScrollbar.js
View file

@ -130,8 +130,18 @@ export default class IndicatorScrollbar extends React.Component {
const yRetention = 1.0; const yRetention = 1.0;
if (Math.abs(e.deltaX) <= xyThreshold) { if (Math.abs(e.deltaX) <= xyThreshold) {
// HACK: We increase the amount of scroll to counteract smooth scrolling browsers.
// Smooth scrolling browsers (Firefox) use the relative area to determine the scroll
// amount, which means the likely small area of content results in a small amount of
// movement - not what people expect. We pick arbitrary values for when to apply more
// scroll, and how much to apply. On Windows 10, Chrome scrolls 100 units whereas
// Firefox scrolls just 3 due to smooth scrolling.
const additionalScroll = e.deltaY < 0 ? -50 : 50;
// noinspection JSSuspiciousNameCombination // noinspection JSSuspiciousNameCombination
this._scrollElement.scrollLeft += e.deltaY * yRetention; const val = Math.abs(e.deltaY) < 25 ? (e.deltaY + additionalScroll) : e.deltaY;
this._scrollElement.scrollLeft += val * yRetention;
} }
} }
}; };