mirrors/element-web
1
0
Fork 0
mirror of https://github.com/element-hq/element-web synced 2024-10-27 21:18:13 +03:00
Code Issues Projects Releases Packages Wiki Activity

add some comments and initialization for async filling

Browse source
This commit is contained in:
Bruno Windels 2019-03-26 13:34:55 +01:00
parent 18b5041ed2
commit 82a9b348c0
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/components/structures/ScrollPanel.js
View file

@ -154,6 +154,8 @@ module.exports = React.createClass({
}, },
componentWillMount: function() { componentWillMount: function() {
this._fillRequestWhileRunning = false;
this._isFilling = false;
this._pendingFillRequests = {b: null, f: null}; this._pendingFillRequests = {b: null, f: null};
if (this.props.resizeNotifier) { if (this.props.resizeNotifier) {
@ -302,6 +304,10 @@ module.exports = React.createClass({
// `---------' - // `---------' -
// //
// as filling is async and recursive,
// don't allow more than 1 chain of calls concurrently
// do make a note when a new request comes in while already running one,
// so we can trigger a new chain of calls once done.
if (isFirstCall) { if (isFirstCall) {
if (this._isFilling) { if (this._isFilling) {
debuglog("_isFilling: not entering while request is ongoing, marking for a subsequent request"); debuglog("_isFilling: not entering while request is ongoing, marking for a subsequent request");
@ -408,6 +414,10 @@ module.exports = React.createClass({
// events) so make sure we set this before firing off the call. // events) so make sure we set this before firing off the call.
this._pendingFillRequests[dir] = true; this._pendingFillRequests[dir] = true;
// wait 1ms before paginating, because otherwise
// this will block the scroll event handler for +700ms
// if messages are already cached in memory,
// This would cause jumping to happen on Chrome/macOS.
return new Promise(resolve => setTimeout(resolve, 1)).then(() => { return new Promise(resolve => setTimeout(resolve, 1)).then(() => {
return this.props.onFillRequest(backwards); return this.props.onFillRequest(backwards);
}).finally(() => { }).finally(() => {