mirrors/element-web
1
0
Fork 0
mirror of https://github.com/element-hq/element-web synced 2024-11-27 11:47:23 +03:00
Code Issues Projects Releases Packages Wiki Activity

Live location sharing: fix code smells - return useEffect unsub, dont map (#8535)

Browse source 
Signed-off-by: Kerry Archibald <kerrya@element.io>
This commit is contained in:
Kerry 2022-05-09 10:42:05 +02:00 committed by GitHub
parent aa8e3dbfb4
commit 7e15bef062
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/components/views/beacon/LeftPanelLiveShareWarning.tsx
View file

@ -68,13 +68,13 @@ const useLivenessMonitor = (liveBeaconIds: BeaconIdentifier[], beacons: Map<Beac
// refresh beacon monitors when the tab becomes active again // refresh beacon monitors when the tab becomes active again
const onPageVisibilityChanged = () => { const onPageVisibilityChanged = () => {
if (document.visibilityState === 'visible') { if (document.visibilityState === 'visible') {
liveBeaconIds.map(identifier => beacons.get(identifier)?.monitorLiveness()); liveBeaconIds.forEach(identifier => beacons.get(identifier)?.monitorLiveness());
} }
}; };
if (liveBeaconIds.length) { if (liveBeaconIds.length) {
document.addEventListener("visibilitychange", onPageVisibilityChanged); document.addEventListener("visibilitychange", onPageVisibilityChanged);
} }
() => { return () => {
document.removeEventListener("visibilitychange", onPageVisibilityChanged); document.removeEventListener("visibilitychange", onPageVisibilityChanged);
}; };
}, [liveBeaconIds, beacons]); }, [liveBeaconIds, beacons]);