Do not create account data event for guests (#9407)

* Do not create account data event for guests

* fix test

src/utils/notifications.ts

@@ -31,6 +31,9 @@ export function getLocalNotificationAccountDataEventType(deviceId: string): stri
 }
 
 export async function createLocalNotificationSettingsIfNeeded(cli: MatrixClient): Promise<void> {
+    if (cli.isGuest()) {
+        return;
+    }
     const eventType = getLocalNotificationAccountDataEventType(cli.deviceId);
     const event = cli.getAccountData(eventType);
     // New sessions will create an account data event to signify they support

test/utils/notifications-test.ts

@@ -30,7 +30,12 @@ jest.mock("../../src/settings/SettingsStore");
 
 describe('notifications', () => {
     let accountDataStore = {};
-    const mockClient = getMockClientWithEventEmitter({
+    let mockClient;
+    let accountDataEventKey;
+
+    beforeEach(() => {
+        jest.clearAllMocks();
+        mockClient = getMockClientWithEventEmitter({
             isGuest: jest.fn().mockReturnValue(false),
             getAccountData: jest.fn().mockImplementation(eventType => accountDataStore[eventType]),
             setAccountData: jest.fn().mockImplementation((eventType, content) => {
@@ -40,11 +45,8 @@ describe('notifications', () => {
                 });
             }),
         });
-
-    const accountDataEventKey = getLocalNotificationAccountDataEventType(mockClient.deviceId);
-
-    beforeEach(() => {
         accountDataStore = {};
+        accountDataEventKey = getLocalNotificationAccountDataEventType(mockClient.deviceId);
         mocked(SettingsStore).getValue.mockReturnValue(false);
     });
 
@@ -55,6 +57,13 @@ describe('notifications', () => {
             expect(event?.getContent().is_silenced).toBe(true);
         });
 
+        it('does not do anything for guests', async () => {
+            mockClient.isGuest.mockReset().mockReturnValue(true);
+            await createLocalNotificationSettingsIfNeeded(mockClient);
+            const event = mockClient.getAccountData(accountDataEventKey);
+            expect(event).toBeFalsy();
+        });
+
         it.each(deviceNotificationSettingsKeys)(
             'unsilenced for existing sessions when %s setting is truthy',
             async (settingKey) => {