diff --git a/src/components/views/right_panel/RoomHeaderButtons.js b/src/components/views/right_panel/RoomHeaderButtons.js
index 950fa30e38..9ccd94e117 100644
--- a/src/components/views/right_panel/RoomHeaderButtons.js
+++ b/src/components/views/right_panel/RoomHeaderButtons.js
@@ -45,8 +45,6 @@ export default class RoomHeaderButtons extends HeaderButtons {
} else {
this.setPhase(RightPanel.Phase.RoomMemberList);
}
- } else if (payload.action === "view_room" && !this.props.collapsedRhs) {
- this.setPhase(RightPanel.Phase.RoomMemberList);
} else if (payload.action === "view_3pid_invite") {
if (payload.event) {
this.setPhase(RightPanel.Phase.Room3pidMemberInfo, {event: payload.event});
diff --git a/src/components/views/rooms/RoomHeader.js b/src/components/views/rooms/RoomHeader.js
index 5b6c0f6d2d..7c74717ed3 100644
--- a/src/components/views/rooms/RoomHeader.js
+++ b/src/components/views/rooms/RoomHeader.js
@@ -39,7 +39,6 @@ module.exports = createReactClass({
room: PropTypes.object,
oobData: PropTypes.object,
inRoom: PropTypes.bool,
- collapsedRhs: PropTypes.bool,
onSettingsClick: PropTypes.func,
onPinnedClick: PropTypes.func,
onSearchClick: PropTypes.func,
@@ -304,7 +303,7 @@ module.exports = createReactClass({
{ topicElement }
{ cancelButton }
{ rightRow }
-
+
);
diff --git a/src/settings/Settings.js b/src/settings/Settings.js
index 53a95c9c6d..82dd639819 100644
--- a/src/settings/Settings.js
+++ b/src/settings/Settings.js
@@ -25,8 +25,7 @@ import {
import CustomStatusController from "./controllers/CustomStatusController";
import ThemeController from './controllers/ThemeController';
import ReloadOnChangeController from "./controllers/ReloadOnChangeController";
-import RightPanel from "../components/structures/RightPanel";
-import {RIGHT_PANEL_PHASES} from "../stores/RightPanelStore";
+import {RIGHT_PANEL_PHASES} from "../stores/RightPanelStorePhases";
// These are just a bunch of helper arrays to avoid copy/pasting a bunch of times
const LEVELS_ROOM_SETTINGS = ['device', 'room-device', 'room-account', 'account', 'config'];
diff --git a/src/stores/RightPanelStore.js b/src/stores/RightPanelStore.js
index fe4be81fd6..0d66e825ea 100644
--- a/src/stores/RightPanelStore.js
+++ b/src/stores/RightPanelStore.js
@@ -17,6 +17,7 @@ limitations under the License.
import dis from '../dispatcher';
import {Store} from 'flux/utils';
import SettingsStore, {SettingLevel} from "../settings/SettingsStore";
+import {RIGHT_PANEL_PHASES} from "./RightPanelStorePhases";
const INITIAL_STATE = {
// Whether or not to show the right panel at all. We split out rooms and groups
@@ -29,21 +30,6 @@ const INITIAL_STATE = {
lastGroupPhase: SettingsStore.getValue("lastRightPanelPhaseForGroup"),
};
-export const RIGHT_PANEL_PHASES = Object.freeze({
- // Room stuff
- RoomMemberList: 'RoomMemberList',
- FilePanel: 'FilePanel',
- NotificationPanel: 'NotificationPanel',
- RoomMemberInfo: 'RoomMemberInfo',
- Room3pidMemberInfo: 'Room3pidMemberInfo',
-
- // Group stuff
- GroupMemberList: 'GroupMemberList',
- GroupRoomList: 'GroupRoomList',
- GroupRoomInfo: 'GroupRoomInfo',
- GroupMemberInfo: 'GroupMemberInfo',
-});
-
const GROUP_PHASES = Object.keys(RIGHT_PANEL_PHASES).filter(k => k.startsWith("Group"));
/**
diff --git a/src/stores/RightPanelStorePhases.js b/src/stores/RightPanelStorePhases.js
new file mode 100644
index 0000000000..83a6d97345
--- /dev/null
+++ b/src/stores/RightPanelStorePhases.js
@@ -0,0 +1,31 @@
+/*
+Copyright 2019 The Matrix.org Foundation C.I.C.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+// These are in their own file because of circular imports being a problem.
+export const RIGHT_PANEL_PHASES = Object.freeze({
+ // Room stuff
+ RoomMemberList: 'RoomMemberList',
+ FilePanel: 'FilePanel',
+ NotificationPanel: 'NotificationPanel',
+ RoomMemberInfo: 'RoomMemberInfo',
+ Room3pidMemberInfo: 'Room3pidMemberInfo',
+
+ // Group stuff
+ GroupMemberList: 'GroupMemberList',
+ GroupRoomList: 'GroupRoomList',
+ GroupRoomInfo: 'GroupRoomInfo',
+ GroupMemberInfo: 'GroupMemberInfo',
+});