mirrors/element-web
1
0
Fork 0
mirror of https://github.com/element-hq/element-web.git synced 2024-12-04 13:15:58 +03:00
Code Issues Projects Releases Packages Wiki Activity

Give Login an unmounted guard

Browse source
This commit is contained in:
Richard van der Hoff 2017-07-11 17:03:25 +01:00
parent 3e93930dcc
commit 67372d4fed
1 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/components/structures/login/Login.js
View file

@ -72,9 +72,14 @@ module.exports = React.createClass({
}, },
componentWillMount: function() { componentWillMount: function() {
this._unmounted = false;
this._initLoginLogic(); this._initLoginLogic();
}, },
componentWillUnmount: function() {
this._unmounted = true;
},
onPasswordLogin: function(username, phoneCountry, phoneNumber, password) { onPasswordLogin: function(username, phoneCountry, phoneNumber, password) {
this.setState({ this.setState({
busy: true, busy: true,
@ -87,6 +92,9 @@ module.exports = React.createClass({
).then((data) => { ).then((data) => {
this.props.onLoggedIn(data); this.props.onLoggedIn(data);
}, (error) => { }, (error) => {
if(this._unmounted) {
return;
}
let errorText; let errorText;
// Some error strings only apply for logging in // Some error strings only apply for logging in
@ -109,8 +117,11 @@ module.exports = React.createClass({
loginIncorrect: error.httpStatus === 401 || error.httpStatus == 403, loginIncorrect: error.httpStatus === 401 || error.httpStatus == 403,
}); });
}).finally(() => { }).finally(() => {
if(this._unmounted) {
return;
}
this.setState({ this.setState({
busy: false busy: false,
}); });
}).done(); }).done();
}, },