Fix various type definitions

src/settings/controllers/FontSizeController.ts

@@ -18,13 +18,14 @@ import SettingController from "./SettingController";
 import dis from "../../dispatcher/dispatcher";
 import { UpdateFontSizePayload } from "../../dispatcher/payloads/UpdateFontSizePayload";
 import { Action } from "../../dispatcher/actions";
+import { SettingLevel } from "../SettingLevel";
 
 export default class FontSizeController extends SettingController {
     constructor() {
         super();
     }
 
-    onChange(level, roomId, newValue) {
+    public onChange(level: SettingLevel, roomId: string, newValue: any) {
         // Dispatch font size change so that everything open responds to the change.
         dis.dispatch<UpdateFontSizePayload>({
             action: Action.UpdateFontSize,

src/settings/controllers/NotificationControllers.ts

@@ -61,7 +61,7 @@ export class NotificationsEnabledController extends SettingController {
         return calculatedValue;
     }
 
-    public onChange(level: SettingLevel, roomId: string, newValue) {
+    public onChange(level: SettingLevel, roomId: string, newValue: any) {
         if (getNotifier().supportsDesktopNotifications()) {
             getNotifier().setEnabled(newValue);
         }

src/settings/controllers/SystemFontController.ts

@@ -19,13 +19,14 @@ import SettingsStore from "../SettingsStore";
 import dis from "../../dispatcher/dispatcher";
 import { UpdateSystemFontPayload } from "../../dispatcher/payloads/UpdateSystemFontPayload";
 import { Action } from "../../dispatcher/actions";
+import { SettingLevel } from "../SettingLevel";
 
 export default class SystemFontController extends SettingController {
     constructor() {
         super();
     }
 
-    public onChange(level, roomId, newValue) {
+    public onChange(level: SettingLevel, roomId: string, newValue: any) {
         // Dispatch font size change so that everything open responds to the change.
         dis.dispatch<UpdateSystemFontPayload>({
             action: Action.UpdateSystemFont,

src/settings/controllers/UseSystemFontController.ts

@@ -19,13 +19,14 @@ import SettingsStore from "../SettingsStore";
 import dis from "../../dispatcher/dispatcher";
 import { UpdateSystemFontPayload } from "../../dispatcher/payloads/UpdateSystemFontPayload";
 import { Action } from "../../dispatcher/actions";
+import { SettingLevel } from "../SettingLevel";
 
 export default class UseSystemFontController extends SettingController {
     constructor() {
         super();
     }
 
-    public onChange(level, roomId, newValue) {
+    public onChange(level: SettingLevel, roomId: string, newValue: any) {
         // Dispatch font size change so that everything open responds to the change.
         dis.dispatch<UpdateSystemFontPayload>({
             action: Action.UpdateSystemFont,

src/settings/handlers/DefaultSettingsHandler.ts

@@ -27,7 +27,7 @@ export default class DefaultSettingsHandler extends SettingsHandler {
      * @param {object} defaults The default setting values, keyed by setting name.
      * @param {object} invertedDefaults The default inverted setting values, keyed by setting name.
      */
-    constructor(private defaults: any, private invertedDefaults: any) { // TODO: [TS] Appropriate types
+    constructor(private defaults: Record<string, any>, private invertedDefaults: Record<string, any>) {
         super();
     }
 

src/settings/handlers/LocalEchoWrapper.ts

@@ -60,7 +60,7 @@ export default class LocalEchoWrapper extends SettingsHandler {
         });
     }
 
-    public canSetValue(settingName, roomId): boolean {
+    public canSetValue(settingName: string, roomId: string): boolean {
         return this.handler.canSetValue(settingName, roomId);
     }