From d0383e3cd52882ed6c363f5e2800f2d61253616a Mon Sep 17 00:00:00 2001 From: Andy Balaam Date: Fri, 10 Nov 2023 11:26:30 +0000 Subject: [PATCH 1/2] Disable 'A room with an edit ... restart' because flaking on Rust --- cypress/e2e/read-receipts/editing-messages.spec.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/cypress/e2e/read-receipts/editing-messages.spec.ts b/cypress/e2e/read-receipts/editing-messages.spec.ts index c5ccb77750..6ab2da349e 100644 --- a/cypress/e2e/read-receipts/editing-messages.spec.ts +++ b/cypress/e2e/read-receipts/editing-messages.spec.ts @@ -19,6 +19,7 @@ limitations under the License. /// import { HomeserverInstance } from "../../plugins/utils/homeserver"; +import { skipIfRustCrypto } from "../../support/util"; import { assertRead, assertReadThread, @@ -179,6 +180,10 @@ describe("Read receipts", () => { assertStillRead(room2); }); it("A room with an edit is still read after restart", () => { + // Flaky with rust crypto + // See https://github.com/vector-im/element-web/issues/26341 + skipIfRustCrypto(); + // Given a message is marked as read goTo(room2); receiveMessages(room2, ["Msg1"]); From c1a060bac6728a0d16ad21f32b53d357a482d4ae Mon Sep 17 00:00:00 2001 From: Andy Balaam Date: Fri, 10 Nov 2023 11:40:08 +0000 Subject: [PATCH 2/2] Disable everywhere since we saw another flake --- cypress/e2e/read-receipts/editing-messages.spec.ts | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/cypress/e2e/read-receipts/editing-messages.spec.ts b/cypress/e2e/read-receipts/editing-messages.spec.ts index 6ab2da349e..bbaa15d659 100644 --- a/cypress/e2e/read-receipts/editing-messages.spec.ts +++ b/cypress/e2e/read-receipts/editing-messages.spec.ts @@ -19,7 +19,6 @@ limitations under the License. /// import { HomeserverInstance } from "../../plugins/utils/homeserver"; -import { skipIfRustCrypto } from "../../support/util"; import { assertRead, assertReadThread, @@ -179,11 +178,8 @@ describe("Read receipts", () => { // Then the room remains read assertStillRead(room2); }); - it("A room with an edit is still read after restart", () => { - // Flaky with rust crypto - // See https://github.com/vector-im/element-web/issues/26341 - skipIfRustCrypto(); - + // XXX: fails because flaky: https://github.com/vector-im/element-web/issues/26341 + it.skip("A room with an edit is still read after restart", () => { // Given a message is marked as read goTo(room2); receiveMessages(room2, ["Msg1"]);