mirrors/element-web
1
0
Fork 0
mirror of https://github.com/element-hq/element-web synced 2024-11-27 03:36:07 +03:00
Code Issues Projects Releases Packages Wiki Activity

Fundamental behaviour, not return type

Browse source
This commit is contained in:
David Baker 2024-05-10 16:52:19 +01:00
parent f2da5fcf2c
commit 5f1f018a30
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
code_style.md
View file

@ -225,11 +225,11 @@ Unless otherwise specified, the following applies to all code:
}
```
37. Avoid functions whose behaviour / return type varies with different parameter types.
Multiple return types are fine, but the function's fundamental behaviour should not
change according its arguments: have two separate functions. For example, `SDKConfig.get()`
with a string param which returns the type according to the param given is ok, but `SDKConfig.get()`
with no args returning the whole config object would not be: this should just be a separate function.
37. Avoid functions whose fundamental behaviour varies with different parameter types.
Multiple return types are fine, but if the function's behaviour is going to change significantly,
have two separate functions. For example, `SDKConfig.get()` with a string param which returns the
type according to the param given is ok, but `SDKConfig.get()` with no args returning the whole
config object would not be: this should just be a separate function.
## React