mirrors/element-web
1
0
Fork 0
mirror of https://github.com/element-hq/element-web synced 2024-10-23 03:05:45 +03:00
Code Issues Projects Releases Packages Wiki Activity

Code review related changes

Browse source 
* drop room ID from jitsi widget data
* reame queryParts variable
This commit is contained in:
Jason Robinson 2020-09-08 11:31:40 +03:00
parent d2e9ea58fd
commit 4b43e39d2a
2 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/CallHandler.js
View file

@ -416,7 +416,6 @@ async function _startCallApp(roomId, type) {
isAudioOnly: type === 'voice', isAudioOnly: type === 'voice',
domain: jitsiDomain, domain: jitsiDomain,
auth: jitsiAuth, auth: jitsiAuth,
roomId: roomId,
}; };
const widgetId = ( const widgetId = (

6
src/utils/WidgetUtils.js
View file

@ -450,7 +450,7 @@ export default class WidgetUtils {
static getLocalJitsiWrapperUrl(opts: {forLocalRender?: boolean, auth?: string}={}) { static getLocalJitsiWrapperUrl(opts: {forLocalRender?: boolean, auth?: string}={}) {
// NB. we can't just encodeURIComponent all of these because the $ signs need to be there // NB. we can't just encodeURIComponent all of these because the $ signs need to be there
const queryParts = [ const queryStringParts = [
'conferenceDomain=$domain', 'conferenceDomain=$domain',
'conferenceId=$conferenceId', 'conferenceId=$conferenceId',
'isAudioOnly=$isAudioOnly', 'isAudioOnly=$isAudioOnly',
@ -460,9 +460,9 @@ export default class WidgetUtils {
'roomId=$matrix_room_id', 'roomId=$matrix_room_id',
]; ];
if (opts.auth) { if (opts.auth) {
queryParts.push(`auth=${opts.auth}`); queryStringParts.push(`auth=${opts.auth}`);
} }
const queryString = queryParts.join('&'); const queryString = queryStringParts.join('&');
let baseUrl = window.location; let baseUrl = window.location;
if (window.location.protocol !== "https:" && !opts.forLocalRender) { if (window.location.protocol !== "https:" && !opts.forLocalRender) {