Iterate PR based on feedback

This commit is contained in:
Michael Telatynski 2021-06-03 08:35:12 +01:00
parent 1ff870927a
commit 42a3ace82a
2 changed files with 5 additions and 7 deletions

View file

@ -31,7 +31,7 @@ interface IProps {
* Component which shows the global notification list using a TimelinePanel * Component which shows the global notification list using a TimelinePanel
*/ */
@replaceableComponent("structures.NotificationPanel") @replaceableComponent("structures.NotificationPanel")
class NotificationPanel extends React.Component<IProps> { export default class NotificationPanel extends React.PureComponent<IProps> {
render() { render() {
const emptyState = (<div className="mx_RightPanel_empty mx_NotificationPanel_empty"> const emptyState = (<div className="mx_RightPanel_empty mx_NotificationPanel_empty">
<h2>{_t('Youre all caught up')}</h2> <h2>{_t('Youre all caught up')}</h2>
@ -62,5 +62,3 @@ class NotificationPanel extends React.Component<IProps> {
</BaseCard>; </BaseCard>;
} }
} }
export default NotificationPanel;

View file

@ -295,13 +295,13 @@ export default class RightPanel extends React.Component<IProps, IState> {
break; break;
case RightPanelPhases.NotificationPanel: case RightPanelPhases.NotificationPanel:
if (SettingsStore.getValue("feature_pinning")) { panel = <NotificationPanel onClose={this.onClose} />;
panel = <NotificationPanel onClose={this.onClose} />;
}
break; break;
case RightPanelPhases.PinnedMessages: case RightPanelPhases.PinnedMessages:
panel = <PinnedMessagesCard room={this.props.room} onClose={this.onClose} />; if (SettingsStore.getValue("feature_pinning")) {
panel = <PinnedMessagesCard room={this.props.room} onClose={this.onClose} />;
}
break; break;
case RightPanelPhases.FilePanel: case RightPanelPhases.FilePanel: