mirrors/element-web
1
0
Fork 0
mirror of https://github.com/element-hq/element-web synced 2024-10-23 19:25:48 +03:00
Code Issues Projects Releases Packages Wiki Activity

Fix unknonw div props in context menu (#9277)

Browse source
This commit is contained in:
Michael Weimann 2022-09-14 14:05:38 +02:00 committed by GitHub
parent eace4d6894
commit 41960b164b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/components/structures/ContextMenu.tsx
View file

@ -397,6 +397,13 @@ export default class ContextMenu extends React.PureComponent<IProps, IState> {
</FocusLock>;
}
// filter props that are invalid for DOM elements
const {
hasBackground: _hasBackground, // eslint-disable-line @typescript-eslint/no-unused-vars
onFinished: _onFinished, // eslint-disable-line @typescript-eslint/no-unused-vars
...divProps
} = props;
return (
<RovingTabIndexProvider handleHomeEnd handleUpDown onKeyDown={this.onKeyDown}>
{ ({ onKeyDownHandler }) => (
@ -413,7 +420,7 @@ export default class ContextMenu extends React.PureComponent<IProps, IState> {
style={menuStyle}
ref={this.collectContextMenuRect}
role={managed ? "menu" : undefined}
{...props}
{...divProps}
>
{ body }
</div>

2
test/components/views/context_menus/__snapshots__/SpaceContextMenu-test.tsx.snap
View file

@ -194,8 +194,6 @@ exports[`<SpaceContextMenu /> renders menu correctly 1`] = `
/>
<div
className="mx_ContextualMenu"
hasBackground={true}
onFinished={[MockFunction]}
role="menu"
style={Object {}}
>