From 4118faa8340baf61610d78217ed80e715c83474d Mon Sep 17 00:00:00 2001 From: Michael Telatynski <7t3chguy@gmail.com> Date: Sun, 5 Jan 2020 20:31:07 +0000 Subject: [PATCH] When looking at a MemberInfo, clicking on MemberList should close not switch Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --- src/components/views/right_panel/GroupHeaderButtons.js | 9 +++++++-- src/components/views/right_panel/RoomHeaderButtons.js | 9 +++++++-- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/src/components/views/right_panel/GroupHeaderButtons.js b/src/components/views/right_panel/GroupHeaderButtons.js index c134a5d237..f164b6c578 100644 --- a/src/components/views/right_panel/GroupHeaderButtons.js +++ b/src/components/views/right_panel/GroupHeaderButtons.js @@ -66,8 +66,13 @@ export default class GroupHeaderButtons extends HeaderButtons { } _onMembersClicked() { - // This toggles for us, if needed - this.setPhase(RIGHT_PANEL_PHASES.GroupMemberList); + if (this.state.phase === RIGHT_PANEL_PHASES.GroupMemberInfo) { + // send the active phase to trigger a toggle + this.setPhase(RIGHT_PANEL_PHASES.GroupMemberInfo); + } else { + // This toggles for us, if needed + this.setPhase(RIGHT_PANEL_PHASES.GroupMemberList); + } } _onRoomsClicked() { diff --git a/src/components/views/right_panel/RoomHeaderButtons.js b/src/components/views/right_panel/RoomHeaderButtons.js index f59159d1d9..3831a5953e 100644 --- a/src/components/views/right_panel/RoomHeaderButtons.js +++ b/src/components/views/right_panel/RoomHeaderButtons.js @@ -56,8 +56,13 @@ export default class RoomHeaderButtons extends HeaderButtons { } _onMembersClicked() { - // This toggles for us, if needed - this.setPhase(RIGHT_PANEL_PHASES.RoomMemberList); + if (this.state.phase === RIGHT_PANEL_PHASES.RoomMemberInfo) { + // send the active phase to trigger a toggle + this.setPhase(RIGHT_PANEL_PHASES.RoomMemberInfo); + } else { + // This toggles for us, if needed + this.setPhase(RIGHT_PANEL_PHASES.RoomMemberList); + } } _onFilesClicked() {