element-android/changelog.d/5528.bugfix at bdb2d29666b44ee80b17d9c4aa5f5bca379fda28 - mirrors/element-android - Sadium Git

mirrors/element-android

mirror of https://github.com/element-hq/element-android synced 2024-11-24 18:35:40 +03:00

SpiritCroc cd45248f40 Fix modifying the wrong events in TimelineChunk

I was observing cases where builtEvents[modificationIndex] was not
having the same eventId as the udpatedEntity in handleDatabaseChangeSet.

In particular, I observed both cases that
- there was no item in the list yet with the same eventId as the updated
  one
- there was an item with the same eventId already in the list, but at a
  different position.

Whenever this happened, the timeline would render missing, duplicated,
or swapped messages in the timeline.

Instead of relying on the modificationIndex to be the same for both the
change set and builtEvents, look up the proper index by eventId.

2022-03-13 08:19:47 +01:00

1 line

54 B

Text

Raw Blame History

Fix cases of missing, swapped, or duplicated messages