mirrors/element-android
1
0
Fork 0
mirror of https://github.com/element-hq/element-android synced 2024-11-24 10:25:35 +03:00
Code Issues Projects Releases Packages Wiki Activity

Adding comments on some strings and removing non necessary plural

Browse source
This commit is contained in:
Maxime NATUREL 2022-05-18 09:48:34 +02:00
parent cbf8306c6f
commit e9d93194f1
3 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
vector/src/main/java/im/vector/app/core/utils/TextUtils.kt
View file

@ -118,7 +118,7 @@ object TextUtils {
private fun appendHours(context: Context, builder: StringBuilder, hours: Int) {
builder.append(hours)
builder.append(context.resources.getQuantityString(R.plurals.time_unit_hour_short, hours))
builder.append(context.resources.getString(R.string.time_unit_hour_short))
}
private fun appendMinutes(context: Context, builder: StringBuilder, minutes: Int) {

1
vector/src/main/java/im/vector/app/features/home/room/detail/timeline/item/MessageLiveLocationItem.kt
View file

@ -57,7 +57,6 @@ abstract class MessageLiveLocationItem : AbsMessageLocationItem<MessageLiveLocat
holder.locationLiveMessageBanner.stopButton.setOnClickListener {
attributes.callback?.onTimelineItemAction(RoomDetailAction.StopLiveLocationSharing)
}
// TODO adjust Copyright map placement if needed
}
private fun buildViewState(

11
vector/src/main/res/values/strings.xml
View file

@ -322,12 +322,11 @@
<string name="start_chatting">Start Chatting</string>
<string name="spaces">Spaces</string>
<!-- Time units -->
<plurals name="time_unit_hour_short">
<item quantity="one">hour</item>
<item quantity="other">hours</item>
</plurals>
<!-- Time unit for hour: if a short version exists, it should be used -->
<string name="time_unit_hour_short">h</string>
<!-- Time unit for minute: if a short version exists, it should be used -->
<string name="time_unit_minute_short">min</string>
<!-- Time unit for second: if a short version exists, it should be used -->
<string name="time_unit_second_short">sec</string>
<!-- Permissions denied forever -->
@ -3024,8 +3023,10 @@
<string name="location_share_live_started">Loading live location…</string>
<string name="location_share_live_ended">Live location ended</string>
<string name="location_share_live_view">View live location</string>
<!-- Examples of usage: Live until 5:42 PM/Live until 17:42-->
<string name="location_share_live_until">Live until %1$s</string>
<string name="location_share_live_stop">Stop</string>
<!-- Examples of usage: 6h 15min 30sec left/15min 30sec left/30 sec left-->
<string name="location_share_live_remaining_time">%1$s left</string>
<string name="live_location_sharing_notification_title">${app_name} Live Location</string>
<string name="live_location_sharing_notification_description">Location sharing is in progress</string>