mirrors/element-android
1
0
Fork 0
mirror of https://github.com/element-hq/element-android synced 2024-11-27 11:59:12 +03:00
Code Issues Projects Releases Packages Wiki Activity

Use @id and not @+id when referencing ids in layouts - ConstraintLayout

Browse source
This commit is contained in:
Benoit Marty 2021-12-01 22:19:33 +01:00
parent 2d17156861
commit e106ff8de0
17 changed files with 22 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tools/check/forbidden_strings_in_layout.txt
View file

@ -27,5 +27,5 @@
android:textSize===9 android:textSize===9
### Use `@id` and not `@+id` when referencing ids in layouts ### Use `@id` and not `@+id` when referencing ids in layouts
Of="@\+id layout_constraint(.*)="@\+id
accessibilityTraversal(.*)="@\+id accessibilityTraversal(.*)="@\+id

2
vector/src/main/res/layout/alerter_verification_layout.xml
View file

@ -26,7 +26,7 @@
android:layout_height="24dp" android:layout_height="24dp"
android:importantForAccessibility="no" android:importantForAccessibility="no"
android:src="@drawable/ic_shield_warning" android:src="@drawable/ic_shield_warning"
app:layout_constraintCircle="@+id/ivUserAvatar" app:layout_constraintCircle="@id/ivUserAvatar"
app:layout_constraintCircleAngle="135" app:layout_constraintCircleAngle="135"
app:layout_constraintCircleRadius="20dp" app:layout_constraintCircleRadius="20dp"
tools:ignore="MissingConstraints" tools:ignore="MissingConstraints"

2
vector/src/main/res/layout/bottom_sheet_verification.xml
View file

@ -31,7 +31,7 @@
android:id="@+id/otherUserShield" android:id="@+id/otherUserShield"
android:layout_width="16dp" android:layout_width="16dp"
android:layout_height="16dp" android:layout_height="16dp"
app:layout_constraintCircle="@+id/otherUserAvatarImageView" app:layout_constraintCircle="@id/otherUserAvatarImageView"
app:layout_constraintCircleAngle="135" app:layout_constraintCircleAngle="135"
app:layout_constraintCircleRadius="16dp" app:layout_constraintCircleRadius="16dp"
tools:ignore="MissingConstraints" /> tools:ignore="MissingConstraints" />

2
vector/src/main/res/layout/custom_action_item_layout_badge.xml
View file

@ -30,7 +30,7 @@
android:background="@drawable/bg_unread_highlight" android:background="@drawable/bg_unread_highlight"
android:gravity="center" android:gravity="center"
android:textColor="?colorOnError" android:textColor="?colorOnError"
app:layout_constraintCircle="@+id/action_view_icon_image" app:layout_constraintCircle="@id/action_view_icon_image"
app:layout_constraintCircleAngle="45" app:layout_constraintCircleAngle="45"
app:layout_constraintCircleRadius="12dp" app:layout_constraintCircleRadius="12dp"
tools:ignore="MissingConstraints" tools:ignore="MissingConstraints"

2
vector/src/main/res/layout/fragment_matrix_profile.xml
View file

@ -63,7 +63,7 @@
android:layout_width="24dp" android:layout_width="24dp"
android:layout_height="24dp" android:layout_height="24dp"
android:alpha="0" android:alpha="0"
app:layout_constraintCircle="@+id/matrixProfileToolbarAvatarImageView" app:layout_constraintCircle="@id/matrixProfileToolbarAvatarImageView"
app:layout_constraintCircleAngle="135" app:layout_constraintCircleAngle="135"
app:layout_constraintCircleRadius="20dp" app:layout_constraintCircleRadius="20dp"
tools:alpha="1" tools:alpha="1"

4
vector/src/main/res/layout/fragment_room_detail.xml
View file

@ -60,7 +60,7 @@
android:background="@drawable/background_circle" android:background="@drawable/background_circle"
android:padding="2dp" android:padding="2dp"
android:visibility="gone" android:visibility="gone"
app:layout_constraintCircle="@+id/roomToolbarAvatarImageView" app:layout_constraintCircle="@id/roomToolbarAvatarImageView"
app:layout_constraintCircleAngle="135" app:layout_constraintCircleAngle="135"
app:layout_constraintCircleRadius="20dp" app:layout_constraintCircleRadius="20dp"
tools:ignore="MissingConstraints" tools:ignore="MissingConstraints"
@ -77,7 +77,7 @@
android:padding="1dp" android:padding="1dp"
android:src="@drawable/ic_public_room" android:src="@drawable/ic_public_room"
android:visibility="gone" android:visibility="gone"
app:layout_constraintCircle="@+id/roomToolbarAvatarImageView" app:layout_constraintCircle="@id/roomToolbarAvatarImageView"
app:layout_constraintCircleAngle="135" app:layout_constraintCircleAngle="135"
app:layout_constraintCircleRadius="20dp" app:layout_constraintCircleRadius="20dp"
tools:ignore="MissingConstraints" tools:ignore="MissingConstraints"

2
vector/src/main/res/layout/fragment_room_setting_generic.xml
View file

@ -41,7 +41,7 @@
android:id="@+id/roomSettingsDecorationToolbarAvatarImageView" android:id="@+id/roomSettingsDecorationToolbarAvatarImageView"
android:layout_width="24dp" android:layout_width="24dp"
android:layout_height="24dp" android:layout_height="24dp"
app:layout_constraintCircle="@+id/roomSettingsToolbarAvatarImageView" app:layout_constraintCircle="@id/roomSettingsToolbarAvatarImageView"
app:layout_constraintCircleAngle="135" app:layout_constraintCircleAngle="135"
app:layout_constraintCircleRadius="20dp" app:layout_constraintCircleRadius="20dp"
tools:ignore="MissingConstraints" /> tools:ignore="MissingConstraints" />

2
vector/src/main/res/layout/fragment_room_uploads.xml
View file

@ -39,7 +39,7 @@
android:id="@+id/roomUploadsDecorationToolbarAvatarImageView" android:id="@+id/roomUploadsDecorationToolbarAvatarImageView"
android:layout_width="24dp" android:layout_width="24dp"
android:layout_height="24dp" android:layout_height="24dp"
app:layout_constraintCircle="@+id/roomUploadsToolbarAvatarImageView" app:layout_constraintCircle="@id/roomUploadsToolbarAvatarImageView"
app:layout_constraintCircleAngle="135" app:layout_constraintCircleAngle="135"
app:layout_constraintCircleRadius="20dp" app:layout_constraintCircleRadius="20dp"
tools:ignore="MissingConstraints" /> tools:ignore="MissingConstraints" />

6
vector/src/main/res/layout/item_breadcrumbs.xml
View file

@ -46,7 +46,7 @@
android:minHeight="18dp" android:minHeight="18dp"
android:textColor="?colorOnError" android:textColor="?colorOnError"
android:visibility="gone" android:visibility="gone"
app:layout_constraintCircle="@+id/breadcrumbsImageView" app:layout_constraintCircle="@id/breadcrumbsImageView"
app:layout_constraintCircleAngle="45" app:layout_constraintCircleAngle="45"
app:layout_constraintCircleRadius="28dp" app:layout_constraintCircleRadius="28dp"
tools:background="@drawable/bg_unread_highlight" tools:background="@drawable/bg_unread_highlight"
@ -66,7 +66,7 @@
android:textColor="?colorOnPrimary" android:textColor="?colorOnPrimary"
android:textStyle="bold" android:textStyle="bold"
android:visibility="gone" android:visibility="gone"
app:layout_constraintCircle="@+id/breadcrumbsImageView" app:layout_constraintCircle="@id/breadcrumbsImageView"
app:layout_constraintCircleAngle="135" app:layout_constraintCircleAngle="135"
app:layout_constraintCircleRadius="28dp" app:layout_constraintCircleRadius="28dp"
tools:ignore="MissingConstraints" tools:ignore="MissingConstraints"
@ -81,7 +81,7 @@
android:padding="3dp" android:padding="3dp"
android:src="@drawable/ic_edit" android:src="@drawable/ic_edit"
android:visibility="gone" android:visibility="gone"
app:layout_constraintCircle="@+id/breadcrumbsImageView" app:layout_constraintCircle="@id/breadcrumbsImageView"
app:layout_constraintCircleAngle="225" app:layout_constraintCircleAngle="225"
app:layout_constraintCircleRadius="28dp" app:layout_constraintCircleRadius="28dp"
tools:ignore="MissingConstraints" tools:ignore="MissingConstraints"

4
vector/src/main/res/layout/item_editable_square_avatar.xml
View file

@ -41,7 +41,7 @@
android:scaleType="center" android:scaleType="center"
android:src="@drawable/ic_delete" android:src="@drawable/ic_delete"
android:visibility="gone" android:visibility="gone"
app:layout_constraintCircle="@+id/itemEditableAvatarImageContainer" app:layout_constraintCircle="@id/itemEditableAvatarImageContainer"
app:layout_constraintCircleAngle="45" app:layout_constraintCircleAngle="45"
app:layout_constraintCircleRadius="48dp" app:layout_constraintCircleRadius="48dp"
app:tint="?colorError" app:tint="?colorError"
@ -57,7 +57,7 @@
android:contentDescription="@string/a11y_change_avatar" android:contentDescription="@string/a11y_change_avatar"
android:padding="8dp" android:padding="8dp"
android:src="@drawable/ic_camera_plain" android:src="@drawable/ic_camera_plain"
app:layout_constraintCircle="@+id/itemEditableAvatarImageContainer" app:layout_constraintCircle="@id/itemEditableAvatarImageContainer"
app:layout_constraintCircleAngle="135" app:layout_constraintCircleAngle="135"
app:layout_constraintCircleRadius="48dp" app:layout_constraintCircleRadius="48dp"
app:tint="?vctr_content_secondary" app:tint="?vctr_content_secondary"

2
vector/src/main/res/layout/item_profile_matrix_item.xml
View file

@ -45,7 +45,7 @@
android:importantForAccessibility="no" android:importantForAccessibility="no"
android:padding="2dp" android:padding="2dp"
android:visibility="gone" android:visibility="gone"
app:layout_constraintCircle="@+id/matrixItemAvatar" app:layout_constraintCircle="@id/matrixItemAvatar"
app:layout_constraintCircleAngle="135" app:layout_constraintCircleAngle="135"
app:layout_constraintCircleRadius="16dp" app:layout_constraintCircleRadius="16dp"
tools:ignore="MissingConstraints" tools:ignore="MissingConstraints"

2
vector/src/main/res/layout/item_profile_matrix_item_progress.xml
View file

@ -30,7 +30,7 @@
android:id="@+id/matrixItemAvatarDecoration" android:id="@+id/matrixItemAvatarDecoration"
android:layout_width="20dp" android:layout_width="20dp"
android:layout_height="20dp" android:layout_height="20dp"
app:layout_constraintCircle="@+id/matrixItemAvatar" app:layout_constraintCircle="@id/matrixItemAvatar"
app:layout_constraintCircleAngle="135" app:layout_constraintCircleAngle="135"
app:layout_constraintCircleRadius="16dp" app:layout_constraintCircleRadius="16dp"
tools:ignore="MissingConstraints" /> tools:ignore="MissingConstraints" />

2
vector/src/main/res/layout/item_space.xml
View file

@ -47,7 +47,7 @@
android:paddingEnd="4dp" android:paddingEnd="4dp"
android:textColor="?colorOnError" android:textColor="?colorOnError"
android:visibility="gone" android:visibility="gone"
app:layout_constraintCircle="@+id/groupAvatarImageView" app:layout_constraintCircle="@id/groupAvatarImageView"
app:layout_constraintCircleAngle="45" app:layout_constraintCircleAngle="45"
app:layout_constraintCircleRadius="24dp" app:layout_constraintCircleRadius="24dp"
tools:background="@drawable/bg_unread_highlight" tools:background="@drawable/bg_unread_highlight"

2
vector/src/main/res/layout/item_sub_space.xml
View file

@ -47,7 +47,7 @@
android:paddingEnd="4dp" android:paddingEnd="4dp"
android:textColor="?colorOnError" android:textColor="?colorOnError"
android:visibility="gone" android:visibility="gone"
app:layout_constraintCircle="@+id/groupAvatarImageView" app:layout_constraintCircle="@id/groupAvatarImageView"
app:layout_constraintCircleAngle="45" app:layout_constraintCircleAngle="45"
app:layout_constraintCircleRadius="14dp" app:layout_constraintCircleRadius="14dp"
tools:background="@drawable/bg_unread_highlight" tools:background="@drawable/bg_unread_highlight"

2
vector/src/main/res/layout/item_timeline_event_merged_room_creation_stub.xml
View file

@ -56,7 +56,7 @@
app:iconPadding="0dp" app:iconPadding="0dp"
app:iconSize="20dp" app:iconSize="20dp"
app:iconTint="?vctr_content_primary" app:iconTint="?vctr_content_primary"
app:layout_constraintCircle="@+id/creationTileRoomAvatarImageView" app:layout_constraintCircle="@id/creationTileRoomAvatarImageView"
app:layout_constraintCircleAngle="135" app:layout_constraintCircleAngle="135"
app:layout_constraintCircleRadius="34dp" app:layout_constraintCircleRadius="34dp"
tools:ignore="MissingConstraints" /> tools:ignore="MissingConstraints" />

2
vector/src/main/res/layout/view_stub_room_member_profile_header.xml
View file

@ -39,7 +39,7 @@
android:importantForAccessibility="no" android:importantForAccessibility="no"
android:padding="3dp" android:padding="3dp"
android:visibility="gone" android:visibility="gone"
app:layout_constraintCircle="@+id/memberProfileAvatarView" app:layout_constraintCircle="@id/memberProfileAvatarView"
app:layout_constraintCircleAngle="135" app:layout_constraintCircleAngle="135"
app:layout_constraintCircleRadius="64dp" app:layout_constraintCircleRadius="64dp"
tools:ignore="MissingConstraints" tools:ignore="MissingConstraints"

4
vector/src/main/res/layout/view_stub_room_profile_header.xml
View file

@ -28,7 +28,7 @@
android:importantForAccessibility="no" android:importantForAccessibility="no"
android:padding="3dp" android:padding="3dp"
android:visibility="gone" android:visibility="gone"
app:layout_constraintCircle="@+id/roomProfileAvatarView" app:layout_constraintCircle="@id/roomProfileAvatarView"
app:layout_constraintCircleAngle="135" app:layout_constraintCircleAngle="135"
app:layout_constraintCircleRadius="64dp" app:layout_constraintCircleRadius="64dp"
tools:ignore="MissingConstraints" tools:ignore="MissingConstraints"
@ -44,7 +44,7 @@
android:padding="2dp" android:padding="2dp"
android:src="@drawable/ic_public_room" android:src="@drawable/ic_public_room"
android:visibility="gone" android:visibility="gone"
app:layout_constraintCircle="@+id/roomProfileAvatarView" app:layout_constraintCircle="@id/roomProfileAvatarView"
app:layout_constraintCircleAngle="135" app:layout_constraintCircleAngle="135"
app:layout_constraintCircleRadius="64dp" app:layout_constraintCircleRadius="64dp"
tools:ignore="MissingConstraints" tools:ignore="MissingConstraints"