Better code

vector/src/main/java/im/vector/riotx/core/platform/VectorBaseFragment.kt

@@ -263,6 +263,9 @@ abstract class VectorBaseFragment : BaseMvRxFragment(), HasScreenInjector {
         }
     }
 
+    // This should be provided by the framework
+    protected fun invalidateOptionsMenu() = requireActivity().invalidateOptionsMenu()
+
     /* ==========================================================================================
      * Common Dialogs
      * ========================================================================================== */

vector/src/main/java/im/vector/riotx/features/attachments/preview/AttachmentsPreviewFragment.kt

@@ -127,7 +127,7 @@ class AttachmentsPreviewFragment @Inject constructor(
     }
 
     override fun invalidate() = withState(viewModel) { state ->
-        requireActivity().invalidateOptionsMenu()
+        invalidateOptionsMenu()
         if (state.attachments.isEmpty()) {
             requireActivity().setResult(RESULT_CANCELED)
             requireActivity().finish()

vector/src/main/java/im/vector/riotx/features/createdirect/CreateDirectRoomKnownUsersFragment.kt

@@ -149,7 +149,7 @@ class CreateDirectRoomKnownUsersFragment @Inject constructor(
     }
 
     private fun renderSelectedUsers(selectedUsers: Set<User>) {
-        vectorBaseActivity.invalidateOptionsMenu()
+        invalidateOptionsMenu()
         if (selectedUsers.isNotEmpty() && chipGroup.size == 0) {
             selectedUsers.forEach { addChipToGroup(it, chipGroup) }
         }

vector/src/main/java/im/vector/riotx/features/home/room/list/RoomListFragment.kt

@@ -257,7 +257,7 @@ class RoomListFragment @Inject constructor(
                 val newValue = state.hasUnread
                 if (hasUnreadRooms != newValue) {
                     hasUnreadRooms = newValue
-                    requireActivity().invalidateOptionsMenu()
+                    invalidateOptionsMenu()
                 }
             }
             else                      -> Unit