mirrors/element-android
1
0
Fork 0
mirror of https://github.com/element-hq/element-android synced 2024-11-24 02:15:35 +03:00
Code Issues Projects Releases Packages Wiki Activity

Encapsulate callbacks calls into try/catch block

Browse source
This commit is contained in:
Maxime NATUREL 2022-06-09 09:54:49 +02:00
parent 260f73b0c2
commit 755d743b06
1 changed files with 26 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
vector/src/main/java/im/vector/app/features/location/LocationTracker.kt
View file

@ -71,16 +71,16 @@ class LocationTracker @Inject constructor(
Timber.d("start()")
if (locationManager == null) {
callbacks.forEach { it.onNoLocationProviderAvailable() }
Timber.v("LocationManager is not available")
onNoLocationProviderAvailable()
return
}
val providers = locationManager.allProviders
if (providers.isEmpty()) {
callbacks.forEach { it.onNoLocationProviderAvailable() }
Timber.v("There is no location provider available")
onNoLocationProviderAvailable()
} else {
// Take GPS first
providers.sortedByDescending { getProviderPriority(it) }
@ -133,7 +133,7 @@ class LocationTracker @Inject constructor(
* Please ensure adding a callback to receive the value.
*/
fun requestLastKnownLocation() {
lastLocation?.let { location -> callbacks.forEach { it.onLocationUpdate(location) } }
lastLocation?.let { locationData -> onLocationUpdate(locationData) }
}
fun addCallback(callback: Callback) {
@ -190,7 +190,7 @@ class LocationTracker @Inject constructor(
val locationData = location.toLocationData()
lastLocation = locationData
callbacks.forEach { it.onLocationUpdate(location.toLocationData()) }
onLocationUpdate(locationData)
}
override fun onProviderDisabled(provider: String) {
@ -203,10 +203,31 @@ class LocationTracker @Inject constructor(
locationManager?.allProviders
?.takeIf { it.isEmpty() }
?.let {
callbacks.forEach { it.onNoLocationProviderAvailable() }
Timber.e("all providers have been disabled")
onNoLocationProviderAvailable()
}
}
private fun onNoLocationProviderAvailable() {
callbacks.forEach {
try {
it.onNoLocationProviderAvailable()
} catch (error: Exception) {
Timber.e(error, "error in onNoLocationProviderAvailable callback $it")
}
}
}
private fun onLocationUpdate(locationData: LocationData) {
callbacks.forEach {
try {
it.onLocationUpdate(locationData)
} catch (error: Exception) {
Timber.e(error, "error in onLocationUpdate callback $it")
}
}
}
private fun Location.toLocationData(): LocationData {
return LocationData(latitude, longitude, accuracy.toDouble())
}