mirrors/element-android
1
0
Fork 0
mirror of https://github.com/element-hq/element-android synced 2024-11-27 11:59:12 +03:00
Code Issues Projects Releases Packages Wiki Activity

Add a check on suspicious string template.

Browse source 
Especially we want to ensure that the app does not log unexpected content.
This commit is contained in:
Benoit Marty 2022-08-16 16:03:24 +02:00 committed by Benoit Marty
parent 680dc207c0
commit 6ac88a9420
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tools/check/forbidden_strings_in_code.txt
View file

@ -185,3 +185,6 @@ System\.currentTimeMillis\(\)===2
onCreateOptionsMenu onCreateOptionsMenu
onOptionsItemSelected onOptionsItemSelected
onPrepareOptionsMenu onPrepareOptionsMenu
### Suspicious String template. Please check that the string template will behave as expected, i.e. the class field and not the whole object will be used. For instance `Timber.d("$event.type")` is not correct, you should write `Timber.d("${event.type}")`. In the former the whole event content will be logged, since it's a data class. If this is expected (i.e. to fix false positive), please add explicit curly braces (`{` and `}`) around the variable, for instance `"elementLogs.${i}.txt"`
\$[a-zA-Z_]\w*\??\.[a-zA-Z_]