From 3ef2f824e81598c5a6c71a4eaf50cf9c71962b1a Mon Sep 17 00:00:00 2001 From: cfriedlander Date: Fri, 11 Mar 2022 11:10:11 +0100 Subject: [PATCH 1/4] add presence indicator online --- library/ui-styles/src/main/res/values/colors.xml | 4 ++++ library/ui-styles/src/main/res/values/palette_mobile.xml | 3 +++ library/ui-styles/src/main/res/values/theme_dark.xml | 1 + library/ui-styles/src/main/res/values/theme_light.xml | 1 + vector/src/main/res/drawable/ic_presence_online.xml | 2 +- 5 files changed, 10 insertions(+), 1 deletion(-) diff --git a/library/ui-styles/src/main/res/values/colors.xml b/library/ui-styles/src/main/res/values/colors.xml index 75b03a7d2e..0578a598e9 100644 --- a/library/ui-styles/src/main/res/values/colors.xml +++ b/library/ui-styles/src/main/res/values/colors.xml @@ -122,6 +122,10 @@ @color/palette_gray_100 @color/palette_gray_450 + + @color/presence_online + @color/presence_online + @color/palette_prune diff --git a/library/ui-styles/src/main/res/values/palette_mobile.xml b/library/ui-styles/src/main/res/values/palette_mobile.xml index ec2f1d0814..0e5a6865da 100644 --- a/library/ui-styles/src/main/res/values/palette_mobile.xml +++ b/library/ui-styles/src/main/res/values/palette_mobile.xml @@ -54,4 +54,7 @@ @color/palette_azure @color/palette_grape + + @color/palette_element_green + \ No newline at end of file diff --git a/library/ui-styles/src/main/res/values/theme_dark.xml b/library/ui-styles/src/main/res/values/theme_dark.xml index 06670ccd68..7177687fdd 100644 --- a/library/ui-styles/src/main/res/values/theme_dark.xml +++ b/library/ui-styles/src/main/res/values/theme_dark.xml @@ -43,6 +43,7 @@ @color/vctr_presence_indicator_offline_dark + @color/vctr_presence_indicator_online_dark ?vctr_system diff --git a/library/ui-styles/src/main/res/values/theme_light.xml b/library/ui-styles/src/main/res/values/theme_light.xml index c184464320..c90c021591 100644 --- a/library/ui-styles/src/main/res/values/theme_light.xml +++ b/library/ui-styles/src/main/res/values/theme_light.xml @@ -43,6 +43,7 @@ @color/vctr_presence_indicator_offline_light + @color/vctr_presence_indicator_online_light ?vctr_system diff --git a/vector/src/main/res/drawable/ic_presence_online.xml b/vector/src/main/res/drawable/ic_presence_online.xml index 2184f359b2..e5229de3fd 100644 --- a/vector/src/main/res/drawable/ic_presence_online.xml +++ b/vector/src/main/res/drawable/ic_presence_online.xml @@ -16,7 +16,7 @@ From 04aaed7210f766457c45006742aec809d8d2fdf8 Mon Sep 17 00:00:00 2001 From: chagai95 <31655082+chagai95@users.noreply.github.com> Date: Fri, 11 Mar 2022 17:12:58 +0100 Subject: [PATCH 2/4] Change log line --- changelog.d/5513.misc | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/5513.misc diff --git a/changelog.d/5513.misc b/changelog.d/5513.misc new file mode 100644 index 0000000000..62be94d6bb --- /dev/null +++ b/changelog.d/5513.misc @@ -0,0 +1 @@ +Added presence indicator online like it is done for offline. From f8ca2fecd5b71ecc55b5286d3af327b9859bba38 Mon Sep 17 00:00:00 2001 From: chagai95 <31655082+chagai95@users.noreply.github.com> Date: Tue, 15 Mar 2022 17:08:31 +0100 Subject: [PATCH 3/4] Update changelog.d/5513.misc Co-authored-by: Adam Brown --- changelog.d/5513.misc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelog.d/5513.misc b/changelog.d/5513.misc index 62be94d6bb..767a9f1843 100644 --- a/changelog.d/5513.misc +++ b/changelog.d/5513.misc @@ -1 +1 @@ -Added presence indicator online like it is done for offline. +Added online presence indicator attribute online to match offline styling From 4a7646a7ba7fcf4896c50645038e3c5ba6019ee6 Mon Sep 17 00:00:00 2001 From: Adam Brown Date: Tue, 15 Mar 2022 17:59:37 +0000 Subject: [PATCH 4/4] providing online indicator color from the colors file instead of the element palette --- library/ui-styles/src/main/res/values/colors.xml | 4 ++-- library/ui-styles/src/main/res/values/palette_mobile.xml | 4 ---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/library/ui-styles/src/main/res/values/colors.xml b/library/ui-styles/src/main/res/values/colors.xml index 0578a598e9..d887e7774e 100644 --- a/library/ui-styles/src/main/res/values/colors.xml +++ b/library/ui-styles/src/main/res/values/colors.xml @@ -123,8 +123,8 @@ @color/palette_gray_450 - @color/presence_online - @color/presence_online + @color/palette_element_green + @color/palette_element_green diff --git a/library/ui-styles/src/main/res/values/palette_mobile.xml b/library/ui-styles/src/main/res/values/palette_mobile.xml index 0e5a6865da..5610771f8a 100644 --- a/library/ui-styles/src/main/res/values/palette_mobile.xml +++ b/library/ui-styles/src/main/res/values/palette_mobile.xml @@ -53,8 +53,4 @@ @color/palette_verde @color/palette_azure @color/palette_grape - - - @color/palette_element_green - \ No newline at end of file