Code review accessibility

This commit is contained in:
Valere 2020-04-23 16:13:19 +02:00
parent 449be02f53
commit 4c4ec6cfe8
2 changed files with 5 additions and 7 deletions

View file

@ -3,10 +3,11 @@
xmlns:app="http://schemas.android.com/apk/res-auto" xmlns:app="http://schemas.android.com/apk/res-auto"
android:id="@+id/itemVerificationNoticeText" android:id="@+id/itemVerificationNoticeText"
android:layout_width="match_parent" android:layout_width="match_parent"
android:paddingBottom="8dp" android:layout_height="wrap_content"
android:contentDescription="@string/use_other_session_content_description"
android:paddingStart="16dp" android:paddingStart="16dp"
android:paddingEnd="16dp" android:paddingEnd="16dp"
android:layout_height="wrap_content"> android:paddingBottom="8dp">
<TextView <TextView
android:id="@+id/use_latest_riot" android:id="@+id/use_latest_riot"
@ -25,7 +26,6 @@
android:layout_width="40dp" android:layout_width="40dp"
android:layout_height="40dp" android:layout_height="40dp"
android:layout_marginTop="16dp" android:layout_marginTop="16dp"
android:contentDescription="@string/monitor_content_description"
android:scaleType="fitCenter" android:scaleType="fitCenter"
android:src="@drawable/ic_monitor" android:src="@drawable/ic_monitor"
android:tint="@color/riotx_notice_secondary" android:tint="@color/riotx_notice_secondary"
@ -38,7 +38,6 @@
android:layout_width="40dp" android:layout_width="40dp"
android:layout_height="40dp" android:layout_height="40dp"
android:layout_marginTop="16dp" android:layout_marginTop="16dp"
android:contentDescription="@string/monitor_content_description"
android:scaleType="fitCenter" android:scaleType="fitCenter"
android:src="@drawable/ic_smartphone" android:src="@drawable/ic_smartphone"
android:tint="@color/riotx_notice_secondary" android:tint="@color/riotx_notice_secondary"
@ -83,10 +82,10 @@
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_marginTop="16dp" android:layout_marginTop="16dp"
android:textSize="12sp"
android:gravity="center" android:gravity="center"
android:text="@string/or_other_mx_capabale_client" android:text="@string/or_other_mx_capabale_client"
android:textColor="?riotx_text_secondary" android:textColor="?riotx_text_secondary"
android:textSize="12sp"
app:layout_constraintEnd_toEndOf="parent" app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent" app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@id/labelsBarrier" /> app:layout_constraintTop_toBottomOf="@id/labelsBarrier" />

View file

@ -6,8 +6,7 @@
<!-- Sections has been created to limit merge conflicts. --> <!-- Sections has been created to limit merge conflicts. -->
<!-- BEGIN Strings added by Valere --> <!-- BEGIN Strings added by Valere -->
<string name="monitor_content_description">Monitor</string> <string name="use_other_session_content_description">Use the latest Riot on your other devices, Riot Web, Riot Desktop, Riot iOS, Riot X for Android, or another cross-signing capable Matrix client</string>
<string name="mobile_content_description">Smartphone</string>
<string name="riot_desktop_web">Riot Web\nRiot Desktop</string> <string name="riot_desktop_web">Riot Web\nRiot Desktop</string>
<string name="riot_ios_android">Riot iOS\nRiot X for Android</string> <string name="riot_ios_android">Riot iOS\nRiot X for Android</string>
<string name="or_other_mx_capabale_client">or another cross-signing capable Matrix client</string> <string name="or_other_mx_capabale_client">or another cross-signing capable Matrix client</string>