crypto: Rename the share_group_session method

This commit is contained in:
Damir Jelić 2021-04-20 14:34:32 +02:00
parent 09c0ca10e5
commit 389273d56a
4 changed files with 10 additions and 10 deletions

View file

@ -535,7 +535,7 @@ internal class DefaultCryptoService @Inject constructor(
val t0 = System.currentTimeMillis()
Timber.v("## CRYPTO | encryptEventContent() starts")
runCatching {
preshareGroupSession(roomId, userIds)
preshareRoomKey(roomId, userIds)
val content = encrypt(roomId, eventType, eventContent)
Timber.v("## CRYPTO | encryptEventContent() : succeeds after ${System.currentTimeMillis() - t0} ms")
MXEncryptEventContentResult(content, EventType.ENCRYPTED)
@ -694,7 +694,7 @@ internal class DefaultCryptoService @Inject constructor(
}
}
private suspend fun preshareGroupSession(roomId: String, roomMembers: List<String>) {
private suspend fun preshareRoomKey(roomId: String, roomMembers: List<String>) {
keyClaimLock.withLock {
val request = olmMachine!!.getMissingSessions(roomMembers)
if (request != null) {
@ -711,7 +711,7 @@ internal class DefaultCryptoService @Inject constructor(
keyShareLock.withLock {
coroutineScope {
olmMachine!!.shareGroupSession(roomId, roomMembers).map {
olmMachine!!.shareRoomKey(roomId, roomMembers).map {
when (it) {
is Request.ToDevice -> {
async {
@ -1077,7 +1077,7 @@ internal class DefaultCryptoService @Inject constructor(
}
runCatching {
preshareGroupSession(roomId, userIds)
preshareRoomKey(roomId, userIds)
}.fold(
{ callback.onSuccess(Unit) },
{

View file

@ -262,7 +262,7 @@ internal class OlmMachine(user_id: String, device_id: String, path: File, device
* mark_request_as_sent() method.
*
* This method should be called every time before a call to
* share_group_session() is made.
* shareRoomKey() is made.
*
* @param users The list of users for which we would like to establish 1:1
* Olm sessions for.
@ -294,8 +294,8 @@ internal class OlmMachine(user_id: String, device_id: String, path: File, device
* @return The list of requests that need to be sent out.
*/
@Throws(CryptoStoreErrorException::class)
suspend fun shareGroupSession(roomId: String, users: List<String>): List<Request> = withContext(Dispatchers.IO) {
inner.shareGroupSession(roomId, users)
suspend fun shareRoomKey(roomId: String, users: List<String>): List<Request> = withContext(Dispatchers.IO) {
inner.shareRoomKey(roomId, users)
}
/**
@ -313,7 +313,7 @@ internal class OlmMachine(user_id: String, device_id: String, path: File, device
* using the [`get_missing_sessions()`](#method.get_missing_sessions)
* method. This method call should be locked per call.
*
* 2. Share a room key with all the room members using the share_group_session().
* 2. Share a room key with all the room members using the shareRoomKey().
* This method call should be locked per room.
*
* 3. Encrypt the event using this method.

View file

@ -315,7 +315,7 @@ impl OlmMachine {
///
/// * `users` - The list of users which are considered to be members of the
/// room and should receive the room key.
pub fn share_group_session(
pub fn share_room_key(
&self,
room_id: &str,
users: Vec<String>,

View file

@ -126,7 +126,7 @@ interface OlmMachine {
[Throws=CryptoStoreError]
Request? get_missing_sessions(sequence<string> users);
[Throws=CryptoStoreError]
sequence<Request> share_group_session([ByRef] string room_id, sequence<string> users);
sequence<Request> share_room_key([ByRef] string room_id, sequence<string> users);
[Throws=CryptoStoreError]
Sas start_verification([ByRef] Device device);