Github action should refer to result is 'success', not status is "success".

This commit is contained in:
Michael Kaye 2022-05-10 15:38:56 +01:00
parent 304cb07858
commit 3769dad30e
2 changed files with 3 additions and 3 deletions

View file

@ -285,7 +285,7 @@ jobs:
codecov-units: codecov-units:
name: Unit tests with code coverage name: Unit tests with code coverage
needs: should-i-run needs: should-i-run
runs-on: macos-latest runs-on: ubuntu-latest
steps: steps:
- uses: actions/checkout@v3 - uses: actions/checkout@v3
- uses: actions/setup-java@v3 - uses: actions/setup-java@v3
@ -318,7 +318,7 @@ jobs:
- integration-tests - integration-tests
- ui-tests - ui-tests
- codecov-units - codecov-units
if: always() && (needs.should-i-run.status == 'success' ) && ((needs.codecov-units.status != 'success' ) || (needs.ui-tests.status != 'success') || (needs.integration-tests.status != 'success')) if: always() && (needs.should-i-run.result == 'success' ) && ((needs.codecov-units.result != 'success' ) || (needs.ui-tests.result != 'success') || (needs.integration-tests.result != 'success'))
# No concurrency required, runs every time on a schedule. # No concurrency required, runs every time on a schedule.
steps: steps:
- uses: michaelkaye/matrix-hookshot-action@v1.0.0 - uses: michaelkaye/matrix-hookshot-action@v1.0.0

View file

@ -71,7 +71,7 @@ jobs:
needs: needs:
- sonarqube - sonarqube
- codecov-units - codecov-units
if: always() && (needs.sonarqube.result != "success" || needs.codecov-units.result != "success") if: always() && (needs.sonarqube.result != 'success' || needs.codecov-units.result != 'success')
steps: steps:
- uses: michaelkaye/matrix-hookshot-action@v1.0.0 - uses: michaelkaye/matrix-hookshot-action@v1.0.0
with: with: