mirrors/element-android
1
0
Fork 0
mirror of https://github.com/element-hq/element-android synced 2024-11-25 02:45:37 +03:00
Code Issues Projects Releases Packages Wiki Activity

a11y: better presentation for file type selector buttons to screen reader users

Browse source 
Signed-off-by: Peter Vágner <pvdeejay@gmail.com>
This commit is contained in:
Peter Vágner 2019-10-31 06:36:28 +01:00 committed by Peter Vágner
parent 0e49a11e5e
commit 33e35368fc
1 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
vector/src/main/res/layout/view_attachment_type_selector.xml
View file

@ -30,10 +30,12 @@
android:id="@+id/attachmentCameraButton" android:id="@+id/attachmentCameraButton"
style="@style/AttachmentTypeSelectorButton" style="@style/AttachmentTypeSelectorButton"
android:src="@drawable/ic_attachment_camera_white_24dp" android:src="@drawable/ic_attachment_camera_white_24dp"
android:contentDescription="@string/attachment_type_camera"
tools:background="@color/colorAccent" /> tools:background="@color/colorAccent" />
<TextView <TextView
style="@style/AttachmentTypeSelectorLabel" style="@style/AttachmentTypeSelectorLabel"
android:importantForAccessibility="no"
android:text="@string/attachment_type_camera" /> android:text="@string/attachment_type_camera" />
</LinearLayout> </LinearLayout>
@ -50,10 +52,12 @@
android:id="@+id/attachmentGalleryButton" android:id="@+id/attachmentGalleryButton"
style="@style/AttachmentTypeSelectorButton" style="@style/AttachmentTypeSelectorButton"
android:src="@drawable/ic_attachment_gallery_white_24dp" android:src="@drawable/ic_attachment_gallery_white_24dp"
android:contentDescription="@string/attachment_type_gallery"
tools:background="@color/colorAccent" /> tools:background="@color/colorAccent" />
<TextView <TextView
style="@style/AttachmentTypeSelectorLabel" style="@style/AttachmentTypeSelectorLabel"
android:importantForAccessibility="no"
android:text="@string/attachment_type_gallery" /> android:text="@string/attachment_type_gallery" />
</LinearLayout> </LinearLayout>
@ -70,10 +74,12 @@
android:id="@+id/attachmentFileButton" android:id="@+id/attachmentFileButton"
style="@style/AttachmentTypeSelectorButton" style="@style/AttachmentTypeSelectorButton"
android:src="@drawable/ic_attachment_file_white_24dp" android:src="@drawable/ic_attachment_file_white_24dp"
android:contentDescription="@string/attachment_type_file"
tools:background="@color/colorAccent" /> tools:background="@color/colorAccent" />
<TextView <TextView
style="@style/AttachmentTypeSelectorLabel" style="@style/AttachmentTypeSelectorLabel"
android:importantForAccessibility="no"
android:text="@string/attachment_type_file" /> android:text="@string/attachment_type_file" />
</LinearLayout> </LinearLayout>
@ -99,10 +105,12 @@
android:id="@+id/attachmentAudioButton" android:id="@+id/attachmentAudioButton"
style="@style/AttachmentTypeSelectorButton" style="@style/AttachmentTypeSelectorButton"
android:src="@drawable/ic_attachment_audio_white_24dp" android:src="@drawable/ic_attachment_audio_white_24dp"
android:contentDescription="@string/attachment_type_audio"
tools:background="@color/colorAccent" /> tools:background="@color/colorAccent" />
<TextView <TextView
style="@style/AttachmentTypeSelectorLabel" style="@style/AttachmentTypeSelectorLabel"
android:importantForAccessibility="no"
android:text="@string/attachment_type_audio" /> android:text="@string/attachment_type_audio" />
</LinearLayout> </LinearLayout>
@ -119,10 +127,12 @@
android:id="@+id/attachmentContactButton" android:id="@+id/attachmentContactButton"
style="@style/AttachmentTypeSelectorButton" style="@style/AttachmentTypeSelectorButton"
android:src="@drawable/ic_attachment_contact_white_24dp" android:src="@drawable/ic_attachment_contact_white_24dp"
android:contentDescription="@string/attachment_type_contact"
tools:background="@color/colorAccent" /> tools:background="@color/colorAccent" />
<TextView <TextView
style="@style/AttachmentTypeSelectorLabel" style="@style/AttachmentTypeSelectorLabel"
android:importantForAccessibility="no"
android:text="@string/attachment_type_contact" /> android:text="@string/attachment_type_contact" />
</LinearLayout> </LinearLayout>
@ -139,14 +149,16 @@
android:id="@+id/attachmentStickersButton" android:id="@+id/attachmentStickersButton"
style="@style/AttachmentTypeSelectorButton" style="@style/AttachmentTypeSelectorButton"
android:src="@drawable/ic_attachment_stickers_white_24dp" android:src="@drawable/ic_attachment_stickers_white_24dp"
android:contentDescription="@string/attachment_type_sticker"
tools:background="@color/colorAccent" /> tools:background="@color/colorAccent" />
<TextView <TextView
style="@style/AttachmentTypeSelectorLabel" style="@style/AttachmentTypeSelectorLabel"
android:importantForAccessibility="no"
android:text="@string/attachment_type_sticker" /> android:text="@string/attachment_type_sticker" />
</LinearLayout> </LinearLayout>
</LinearLayout> </LinearLayout>
</LinearLayout> </LinearLayout>