mirror of
https://github.com/element-hq/element-android
synced 2024-11-28 05:31:21 +03:00
Renaming some methods to be more concise
This commit is contained in:
parent
6899b5b637
commit
042c57f9b8
3 changed files with 6 additions and 6 deletions
|
@ -17,8 +17,8 @@
|
|||
package im.vector.app.features.media
|
||||
|
||||
interface AttachmentInteractionListener {
|
||||
fun onDismissTapped()
|
||||
fun onShareTapped()
|
||||
fun onDismiss()
|
||||
fun onShare()
|
||||
fun onPlayPause(play: Boolean)
|
||||
fun videoSeekTo(percent: Int)
|
||||
}
|
||||
|
|
|
@ -49,10 +49,10 @@ class AttachmentOverlayView @JvmOverloads constructor(
|
|||
views = MergeImageAttachmentOverlayBinding.bind(this)
|
||||
setBackgroundColor(Color.TRANSPARENT)
|
||||
views.overlayBackButton.setOnClickListener {
|
||||
interactionListener?.onDismissTapped()
|
||||
interactionListener?.onDismiss()
|
||||
}
|
||||
views.overlayShareButton.setOnClickListener {
|
||||
interactionListener?.onShareTapped()
|
||||
interactionListener?.onShare()
|
||||
}
|
||||
views.overlayPlayPauseButton.setOnClickListener {
|
||||
interactionListener?.onPlayPause(!isPlaying)
|
||||
|
|
|
@ -241,7 +241,7 @@ class VectorAttachmentViewerActivity : AttachmentViewerActivity(), AttachmentInt
|
|||
* Specialization AttachmentInteractionListener
|
||||
* ========================================================================================== */
|
||||
|
||||
override fun onDismissTapped() {
|
||||
override fun onDismiss() {
|
||||
animateClose()
|
||||
}
|
||||
|
||||
|
@ -255,7 +255,7 @@ class VectorAttachmentViewerActivity : AttachmentViewerActivity(), AttachmentInt
|
|||
|
||||
// TODO add save feature for image => check it works for video as well,
|
||||
// check if it is already possible to save from menu with long press on video
|
||||
override fun onShareTapped() {
|
||||
override fun onShare() {
|
||||
// TODO the opening of share bottom sheet is extremely slow
|
||||
// move the retrieve of the file into ViewModel and use a ViewEvent to call shareMedia
|
||||
lifecycleScope.launch(Dispatchers.IO) {
|
||||
|
|
Loading…
Reference in a new issue