mirrors/bitwarden-android
1
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2024-11-24 02:15:53 +03:00
Code Issues Projects Releases Packages Wiki Activity

PM-12733: Trim totp codes before saving them (#4315)

Browse source
This commit is contained in:
David Perez 2024-11-18 09:05:00 -06:00 committed by GitHub
parent e90bd136f6
commit ffeae93728
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/manualcodeentry/ManualCodeEntryViewModel.kt
View file

@ -46,7 +46,7 @@ class ManualCodeEntryViewModel @Inject constructor(
} }
private fun handleCodeSubmit() { private fun handleCodeSubmit() {
vaultRepository.emitTotpCodeResult(TotpCodeResult.Success(state.code)) vaultRepository.emitTotpCodeResult(TotpCodeResult.Success(state.code.trim()))
sendEvent(ManualCodeEntryEvent.NavigateBack) sendEvent(ManualCodeEntryEvent.NavigateBack)
} }

3
app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/manualcodeentry/ManualCodeEntryViewModelTests.kt
View file

@ -36,8 +36,7 @@ class ManualCodeEntryViewModelTests : BaseViewModelTest() {
@Test @Test
fun `CodeSubmit should emit new code and NavigateBack`() = runTest { fun `CodeSubmit should emit new code and NavigateBack`() = runTest {
val viewModel = val viewModel = createViewModel(initialState = ManualCodeEntryState(" TestCode "))
createViewModel(initialState = ManualCodeEntryState("TestCode"))
viewModel.eventFlow.test { viewModel.eventFlow.test {
viewModel.trySendAction(ManualCodeEntryAction.CodeSubmit) viewModel.trySendAction(ManualCodeEntryAction.CodeSubmit)