mirrors/bitwarden-android
1
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2024-11-24 10:25:57 +03:00
Code Issues Projects Releases Packages Wiki Activity

Update to detekt 1.23.7 (#3901)

Browse source
This commit is contained in:
David Perez 2024-09-11 11:41:35 -05:00 committed by GitHub
parent a5726fb72b
commit fe1f897d64
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
32 changed files with 39 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/disk/model/EnvironmentUrlDataJson.kt
View file

@ -37,6 +37,7 @@ data class EnvironmentUrlDataJson(
@SerialName("events")
val events: String? = null,
) {
@Suppress("UndocumentedPublicClass")
companion object {
/**
* Default [EnvironmentUrlDataJson] for the US region.

1
app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/PolicyInformation.kt
View file

@ -94,6 +94,7 @@ sealed class PolicyInformation {
@SerialName("includeNumber")
val includeNumber: Boolean?,
) : PolicyInformation() {
@Suppress("UndocumentedPublicClass")
companion object {
const val TYPE_PASSWORD: String = "password"
const val TYPE_PASSPHRASE: String = "passphrase"

2
app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/legacy/LegacySecureStorageMigratorImpl.kt
View file

@ -32,7 +32,7 @@ class LegacySecureStorageMigratorImpl(
}
}
companion object {
private companion object {
private const val ENCRYPTED_BASE_KEY: String = "bwSecureStorage"
}
}

1
app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt
View file

@ -19,6 +19,7 @@ sealed class FlagKey<out T : Any> {
*/
abstract val isRemotelyConfigured: Boolean
@Suppress("UndocumentedPublicClass")
companion object {
/**
* List of all flag keys to consider

2
app/src/main/java/com/x8bit/bitwarden/data/platform/repository/ServerConfigRepositoryImpl.kt
View file

@ -59,7 +59,7 @@ class ServerConfigRepositoryImpl(
return localConfig
}
companion object {
private companion object {
private const val MINIMUM_CONFIG_SYNC_INTERVAL_SEC: Long = 60 * 60
}
}

1
app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/handlers/SetupAutoFillHandler.kt
View file

@ -16,6 +16,7 @@ data class SetupAutoFillHandler(
val onConfirmTurnOnLaterClick: () -> Unit,
val sendAutoFillServiceFallback: () -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
/**
* Convenience function for creating a [SetupAutoFillHandler] with a

1
app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/handlers/SetupUnlockHandler.kt
View file

@ -16,6 +16,7 @@ data class SetupUnlockHandler(
val onSetUpLaterClick: () -> Unit,
val unlockWithBiometricToggle: () -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
/**
* Creates an instance of [SetupUnlockHandler] by binding actions to the provided

1
app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/handlers/CheckEmailHandler.kt
View file

@ -14,6 +14,7 @@ class CheckEmailHandler(
val onBackClick: () -> Unit,
val onLoginClick: () -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
/**
* Create [CheckEmailHandler] with the given [viewModel] to send actions to.

1
app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/handlers/CompleteRegistrationHandler.kt
View file

@ -21,6 +21,7 @@ class CompleteRegistrationHandler(
val onLearnToPreventLockout: () -> Unit,
val onCallToAction: () -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
/**
* Create [CompleteRegistrationHandler] with the given [viewModel] to send actions to.

2
app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/handlers/StartRegistrationHandler.kt
View file

@ -22,7 +22,7 @@ data class StartRegistrationHandler(
val onServerGeologyHelpClick: () -> Unit,
val onBackClick: () -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
/**
* Creates an instance of [StartRegistrationHandler] by binding actions to the provided

1
app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/trusteddevice/handlers/TrustedDeviceHandlers.kt
View file

@ -17,6 +17,7 @@ data class TrustedDeviceHandlers(
val onApproveWithPasswordClick: () -> Unit,
val onNotYouButtonClick: () -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
/**
* Creates an instance of [TrustedDeviceHandlers] by binding actions to the provided

1
app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/handlers/SearchHandlers.kt
View file

@ -20,6 +20,7 @@ data class SearchHandlers(
val onVaultFilterSelect: (VaultFilterType) -> Unit,
val onOverflowItemClick: (ListingItemOverflowAction) -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
/**
* Creates an instance of [SearchHandlers] by binding actions to the provided

1
app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutViewModel.kt
View file

@ -104,6 +104,7 @@ class AboutViewModel @Inject constructor(
)
}
@Suppress("UndocumentedPublicClass")
companion object {
/**
* Create initial state for the About View model.

7
app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt
View file

@ -1348,6 +1348,7 @@ private data class PasswordHandlers(
val onPasswordMinSpecialCharactersChange: (Int) -> Unit,
val onPasswordToggleAvoidAmbiguousCharsChange: (Boolean) -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
@Suppress("LongMethod")
fun create(viewModel: GeneratorViewModel): PasswordHandlers {
@ -1433,6 +1434,7 @@ private data class PassphraseHandlers(
val onPassphraseCapitalizeToggleChange: (Boolean) -> Unit,
val onPassphraseIncludeNumberToggleChange: (Boolean) -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
fun create(viewModel: GeneratorViewModel): PassphraseHandlers {
return PassphraseHandlers(
@ -1482,6 +1484,7 @@ private data class PassphraseHandlers(
private data class UsernameTypeHandlers(
val onUsernameTooltipClicked: () -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
fun create(viewModel: GeneratorViewModel): UsernameTypeHandlers {
return UsernameTypeHandlers(
@ -1513,6 +1516,7 @@ private data class ForwardedEmailAliasHandlers(
val onForwardEmailDomainNameTextChange: (String) -> Unit,
val onSimpleLoginApiKeyTextChange: (String) -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
@Suppress("LongMethod")
fun create(viewModel: GeneratorViewModel): ForwardedEmailAliasHandlers {
@ -1647,6 +1651,7 @@ private data class ForwardedEmailAliasHandlers(
private data class PlusAddressedEmailHandlers(
val onEmailChange: (String) -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
fun create(viewModel: GeneratorViewModel): PlusAddressedEmailHandlers {
return PlusAddressedEmailHandlers(
@ -1676,6 +1681,7 @@ private data class PlusAddressedEmailHandlers(
private data class CatchAllEmailHandlers(
val onDomainChange: (String) -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
fun create(viewModel: GeneratorViewModel): CatchAllEmailHandlers {
return CatchAllEmailHandlers(
@ -1706,6 +1712,7 @@ private data class RandomWordHandlers(
val onCapitalizeChange: (Boolean) -> Unit,
val onIncludeNumberChange: (Boolean) -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
fun create(viewModel: GeneratorViewModel): RandomWordHandlers {
return RandomWordHandlers(

2
app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt
View file

@ -1810,6 +1810,7 @@ data class GeneratorState(
override val displayStringResId: Int
get() = PasscodeTypeOption.PASSWORD.labelRes
@Suppress("UndocumentedPublicClass")
companion object {
private const val DEFAULT_PASSWORD_LENGTH: Int = 14
private const val MIN_NUMBERS: Int = 1
@ -1845,6 +1846,7 @@ data class GeneratorState(
override val displayStringResId: Int
get() = PasscodeTypeOption.PASSPHRASE.labelRes
@Suppress("UndocumentedPublicClass")
companion object {
private const val DEFAULT_PASSPHRASE_SEPARATOR: Char = '-'
private const val DEFAULT_NUM_WORDS: Int = 3

1
app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/handlers/AddSendHandlers.kt
View file

@ -26,6 +26,7 @@ data class AddSendHandlers(
val onExpirationDateChange: (ZonedDateTime?) -> Unit,
val onClearExpirationDateClick: () -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
/**
* Creates an instance of [AddSendHandlers] by binding actions to the provided

1
app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/handlers/SendHandlers.kt
View file

@ -18,6 +18,7 @@ data class SendHandlers(
val onDeleteSendClick: (SendState.ViewState.Content.SendItem) -> Unit,
val onRemovePasswordClick: (SendState.ViewState.Content.SendItem) -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
/**
* Creates an instance of [SendHandlers] by binding actions to the provided [SendViewModel].

1
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditCardTypeHandlers.kt
View file

@ -30,6 +30,7 @@ data class VaultAddEditCardTypeHandlers(
val onSecurityCodeVisibilityChange: (Boolean) -> Unit,
val onNumberVisibilityChange: (Boolean) -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
/**

1
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditCommonHandlers.kt
View file

@ -39,6 +39,7 @@ data class VaultAddEditCommonHandlers(
val onCollectionSelect: (VaultCollection) -> Unit,
val onHiddenFieldVisibilityChange: (Boolean) -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
/**

1
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditIdentityTypeHandlers.kt
View file

@ -46,6 +46,7 @@ data class VaultAddEditIdentityTypeHandlers(
val onZipTextChange: (String) -> Unit,
val onCountryTextChange: (String) -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
/**

1
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditLoginTypeHandlers.kt
View file

@ -43,6 +43,7 @@ data class VaultAddEditLoginTypeHandlers(
val onPasswordVisibilityChange: (Boolean) -> Unit,
val onClearFido2CredentialClick: () -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
/**

1
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditUserVerificationHandlers.kt
View file

@ -24,6 +24,7 @@ data class VaultAddEditUserVerificationHandlers(
val onUserVerificationCancelled: () -> Unit,
val onUserVerificationNotSupported: () -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
/**

1
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/attachments/handlers/AttachmentsHandlers.kt
View file

@ -15,6 +15,7 @@ data class AttachmentsHandlers(
val onDeleteClick: (attachmentId: String) -> Unit,
val onDismissRequest: () -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
/**
* Creates the [AttachmentsHandlers] using the [AttachmentsViewModel] to send desired

1
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultCardItemTypeHandlers.kt
View file

@ -13,6 +13,7 @@ data class VaultCardItemTypeHandlers(
val onShowNumberClick: (Boolean) -> Unit,
val onShowSecurityCodeClick: (Boolean) -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
/**

1
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultCommonItemTypeHandlers.kt
View file

@ -22,6 +22,7 @@ data class VaultCommonItemTypeHandlers(
) -> Unit,
val onAttachmentDownloadClick: (VaultItemState.ViewState.Content.Common.AttachmentItem) -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
/**
* Creates an instance of [VaultCommonItemTypeHandlers] by binding actions

1
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultLoginItemTypeHandlers.kt
View file

@ -18,6 +18,7 @@ data class VaultLoginItemTypeHandlers(
val onPasswordHistoryClick: () -> Unit,
val onShowPasswordClick: (isVisible: Boolean) -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
/**
* Creates the [VaultLoginItemTypeHandlers] using the [viewModel] to send desired actions.

1
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/handlers/VaultItemListingHandlers.kt
View file

@ -26,6 +26,7 @@ data class VaultItemListingHandlers(
val lockClick: () -> Unit,
val overflowItemClick: (action: ListingItemOverflowAction) -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
/**
* Creates an instance of [VaultItemListingHandlers] by binding actions to the provided

1
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/handlers/VaultItemListingUserVerificationHandlers.kt
View file

@ -21,6 +21,7 @@ data class VaultItemListingUserVerificationHandlers(
val onUserVerificationCancelled: () -> Unit,
val onUserVerificationNotSupported: (selectedCipherId: String?) -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
/**

1
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/handlers/VaultHandlers.kt
View file

@ -35,6 +35,7 @@ data class VaultHandlers(
val overflowOptionClick: (ListingItemOverflowAction.VaultAction) -> Unit,
val masterPasswordRepromptSubmit: (ListingItemOverflowAction.VaultAction, String) -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
/**
* Creates an instance of [VaultHandlers] by binding actions to the provided

1
app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/verificationcode/handlers/VerificationCodeHandlers.kt
View file

@ -16,6 +16,7 @@ data class VerificationCodeHandlers(
val lockClick: () -> Unit,
val copyClick: (text: String) -> Unit,
) {
@Suppress("UndocumentedPublicClass")
companion object {
/**
* Creates an instance of [VerificationCodeHandlers] by binding actions to the provided

1
app/src/main/java/com/x8bit/bitwarden/ui/vault/model/VaultLinkedFieldType.kt
View file

@ -45,6 +45,7 @@ enum class VaultLinkedFieldType(
FULL_NAME(id = 418.toUInt(), label = R.string.full_name.asText()),
;
@Suppress("UndocumentedPublicClass")
companion object {
/**
* Helper function to get the LinkedCustomFieldType from the id

2
gradle/libs.versions.toml
View file

@ -26,7 +26,7 @@ androdixAutofill = "1.1.0"
androidxWork = "2.9.1"
bitwardenSdk = "0.5.0-20240819.160739-177"
crashlytics = "3.0.2"
detekt = "1.23.6"
detekt = "1.23.7"
firebaseBom = "33.2.0"
glide = "1.0.0-beta01"
googleServices = "4.4.2"