From fe1f897d64005bf5f1f75de2ef401bf71ed13fb3 Mon Sep 17 00:00:00 2001 From: David Perez Date: Wed, 11 Sep 2024 11:41:35 -0500 Subject: [PATCH] Update to detekt 1.23.7 (#3901) --- .../auth/datasource/disk/model/EnvironmentUrlDataJson.kt | 1 + .../data/auth/repository/model/PolicyInformation.kt | 1 + .../disk/legacy/LegacySecureStorageMigratorImpl.kt | 2 +- .../x8bit/bitwarden/data/platform/manager/model/FlagKey.kt | 1 + .../data/platform/repository/ServerConfigRepositoryImpl.kt | 2 +- .../feature/accountsetup/handlers/SetupAutoFillHandler.kt | 1 + .../feature/accountsetup/handlers/SetupUnlockHandler.kt | 1 + .../auth/feature/checkemail/handlers/CheckEmailHandler.kt | 1 + .../handlers/CompleteRegistrationHandler.kt | 1 + .../startregistration/handlers/StartRegistrationHandler.kt | 2 +- .../trusteddevice/handlers/TrustedDeviceHandlers.kt | 1 + .../ui/platform/feature/search/handlers/SearchHandlers.kt | 1 + .../ui/platform/feature/settings/about/AboutViewModel.kt | 1 + .../ui/tools/feature/generator/GeneratorScreen.kt | 7 +++++++ .../ui/tools/feature/generator/GeneratorViewModel.kt | 2 ++ .../tools/feature/send/addsend/handlers/AddSendHandlers.kt | 1 + .../ui/tools/feature/send/handlers/SendHandlers.kt | 1 + .../addedit/handlers/VaultAddEditCardTypeHandlers.kt | 1 + .../feature/addedit/handlers/VaultAddEditCommonHandlers.kt | 1 + .../addedit/handlers/VaultAddEditIdentityTypeHandlers.kt | 1 + .../addedit/handlers/VaultAddEditLoginTypeHandlers.kt | 1 + .../handlers/VaultAddEditUserVerificationHandlers.kt | 1 + .../feature/attachments/handlers/AttachmentsHandlers.kt | 1 + .../feature/item/handlers/VaultCardItemTypeHandlers.kt | 1 + .../feature/item/handlers/VaultCommonItemTypeHandlers.kt | 1 + .../feature/item/handlers/VaultLoginItemTypeHandlers.kt | 1 + .../itemlisting/handlers/VaultItemListingHandlers.kt | 1 + .../handlers/VaultItemListingUserVerificationHandlers.kt | 1 + .../ui/vault/feature/vault/handlers/VaultHandlers.kt | 1 + .../verificationcode/handlers/VerificationCodeHandlers.kt | 1 + .../x8bit/bitwarden/ui/vault/model/VaultLinkedFieldType.kt | 1 + gradle/libs.versions.toml | 2 +- 32 files changed, 39 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/disk/model/EnvironmentUrlDataJson.kt b/app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/disk/model/EnvironmentUrlDataJson.kt index 8654c6388..738091f49 100644 --- a/app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/disk/model/EnvironmentUrlDataJson.kt +++ b/app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/disk/model/EnvironmentUrlDataJson.kt @@ -37,6 +37,7 @@ data class EnvironmentUrlDataJson( @SerialName("events") val events: String? = null, ) { + @Suppress("UndocumentedPublicClass") companion object { /** * Default [EnvironmentUrlDataJson] for the US region. diff --git a/app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/PolicyInformation.kt b/app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/PolicyInformation.kt index 3cbe14142..dffc7cad7 100644 --- a/app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/PolicyInformation.kt +++ b/app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/PolicyInformation.kt @@ -94,6 +94,7 @@ sealed class PolicyInformation { @SerialName("includeNumber") val includeNumber: Boolean?, ) : PolicyInformation() { + @Suppress("UndocumentedPublicClass") companion object { const val TYPE_PASSWORD: String = "password" const val TYPE_PASSPHRASE: String = "passphrase" diff --git a/app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/legacy/LegacySecureStorageMigratorImpl.kt b/app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/legacy/LegacySecureStorageMigratorImpl.kt index 956d42a4e..dc520bddd 100644 --- a/app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/legacy/LegacySecureStorageMigratorImpl.kt +++ b/app/src/main/java/com/x8bit/bitwarden/data/platform/datasource/disk/legacy/LegacySecureStorageMigratorImpl.kt @@ -32,7 +32,7 @@ class LegacySecureStorageMigratorImpl( } } - companion object { + private companion object { private const val ENCRYPTED_BASE_KEY: String = "bwSecureStorage" } } diff --git a/app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt b/app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt index 008027ca2..4bf506af3 100644 --- a/app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt +++ b/app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/FlagKey.kt @@ -19,6 +19,7 @@ sealed class FlagKey { */ abstract val isRemotelyConfigured: Boolean + @Suppress("UndocumentedPublicClass") companion object { /** * List of all flag keys to consider diff --git a/app/src/main/java/com/x8bit/bitwarden/data/platform/repository/ServerConfigRepositoryImpl.kt b/app/src/main/java/com/x8bit/bitwarden/data/platform/repository/ServerConfigRepositoryImpl.kt index 8ece064ca..df86fc327 100644 --- a/app/src/main/java/com/x8bit/bitwarden/data/platform/repository/ServerConfigRepositoryImpl.kt +++ b/app/src/main/java/com/x8bit/bitwarden/data/platform/repository/ServerConfigRepositoryImpl.kt @@ -59,7 +59,7 @@ class ServerConfigRepositoryImpl( return localConfig } - companion object { + private companion object { private const val MINIMUM_CONFIG_SYNC_INTERVAL_SEC: Long = 60 * 60 } } diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/handlers/SetupAutoFillHandler.kt b/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/handlers/SetupAutoFillHandler.kt index f4d0bf883..7c8c5e3ac 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/handlers/SetupAutoFillHandler.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/handlers/SetupAutoFillHandler.kt @@ -16,6 +16,7 @@ data class SetupAutoFillHandler( val onConfirmTurnOnLaterClick: () -> Unit, val sendAutoFillServiceFallback: () -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { /** * Convenience function for creating a [SetupAutoFillHandler] with a diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/handlers/SetupUnlockHandler.kt b/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/handlers/SetupUnlockHandler.kt index 4086ca650..27c0985a5 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/handlers/SetupUnlockHandler.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/handlers/SetupUnlockHandler.kt @@ -16,6 +16,7 @@ data class SetupUnlockHandler( val onSetUpLaterClick: () -> Unit, val unlockWithBiometricToggle: () -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { /** * Creates an instance of [SetupUnlockHandler] by binding actions to the provided diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/handlers/CheckEmailHandler.kt b/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/handlers/CheckEmailHandler.kt index 464537c19..6aef50f02 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/handlers/CheckEmailHandler.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/handlers/CheckEmailHandler.kt @@ -14,6 +14,7 @@ class CheckEmailHandler( val onBackClick: () -> Unit, val onLoginClick: () -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { /** * Create [CheckEmailHandler] with the given [viewModel] to send actions to. diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/handlers/CompleteRegistrationHandler.kt b/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/handlers/CompleteRegistrationHandler.kt index 2522f9a26..fa4ac92bd 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/handlers/CompleteRegistrationHandler.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/handlers/CompleteRegistrationHandler.kt @@ -21,6 +21,7 @@ class CompleteRegistrationHandler( val onLearnToPreventLockout: () -> Unit, val onCallToAction: () -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { /** * Create [CompleteRegistrationHandler] with the given [viewModel] to send actions to. diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/handlers/StartRegistrationHandler.kt b/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/handlers/StartRegistrationHandler.kt index 9209c6a6c..585dbeaca 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/handlers/StartRegistrationHandler.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/handlers/StartRegistrationHandler.kt @@ -22,7 +22,7 @@ data class StartRegistrationHandler( val onServerGeologyHelpClick: () -> Unit, val onBackClick: () -> Unit, ) { - + @Suppress("UndocumentedPublicClass") companion object { /** * Creates an instance of [StartRegistrationHandler] by binding actions to the provided diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/trusteddevice/handlers/TrustedDeviceHandlers.kt b/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/trusteddevice/handlers/TrustedDeviceHandlers.kt index 3dde3d9d0..bfdb3bbb2 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/trusteddevice/handlers/TrustedDeviceHandlers.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/trusteddevice/handlers/TrustedDeviceHandlers.kt @@ -17,6 +17,7 @@ data class TrustedDeviceHandlers( val onApproveWithPasswordClick: () -> Unit, val onNotYouButtonClick: () -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { /** * Creates an instance of [TrustedDeviceHandlers] by binding actions to the provided diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/handlers/SearchHandlers.kt b/app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/handlers/SearchHandlers.kt index e2e227081..b5b61347b 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/handlers/SearchHandlers.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/handlers/SearchHandlers.kt @@ -20,6 +20,7 @@ data class SearchHandlers( val onVaultFilterSelect: (VaultFilterType) -> Unit, val onOverflowItemClick: (ListingItemOverflowAction) -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { /** * Creates an instance of [SearchHandlers] by binding actions to the provided diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutViewModel.kt b/app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutViewModel.kt index 8a6c17933..6b11035a7 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutViewModel.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutViewModel.kt @@ -104,6 +104,7 @@ class AboutViewModel @Inject constructor( ) } + @Suppress("UndocumentedPublicClass") companion object { /** * Create initial state for the About View model. diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt b/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt index b38f1d0cf..2efbfcfa8 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt @@ -1348,6 +1348,7 @@ private data class PasswordHandlers( val onPasswordMinSpecialCharactersChange: (Int) -> Unit, val onPasswordToggleAvoidAmbiguousCharsChange: (Boolean) -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { @Suppress("LongMethod") fun create(viewModel: GeneratorViewModel): PasswordHandlers { @@ -1433,6 +1434,7 @@ private data class PassphraseHandlers( val onPassphraseCapitalizeToggleChange: (Boolean) -> Unit, val onPassphraseIncludeNumberToggleChange: (Boolean) -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { fun create(viewModel: GeneratorViewModel): PassphraseHandlers { return PassphraseHandlers( @@ -1482,6 +1484,7 @@ private data class PassphraseHandlers( private data class UsernameTypeHandlers( val onUsernameTooltipClicked: () -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { fun create(viewModel: GeneratorViewModel): UsernameTypeHandlers { return UsernameTypeHandlers( @@ -1513,6 +1516,7 @@ private data class ForwardedEmailAliasHandlers( val onForwardEmailDomainNameTextChange: (String) -> Unit, val onSimpleLoginApiKeyTextChange: (String) -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { @Suppress("LongMethod") fun create(viewModel: GeneratorViewModel): ForwardedEmailAliasHandlers { @@ -1647,6 +1651,7 @@ private data class ForwardedEmailAliasHandlers( private data class PlusAddressedEmailHandlers( val onEmailChange: (String) -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { fun create(viewModel: GeneratorViewModel): PlusAddressedEmailHandlers { return PlusAddressedEmailHandlers( @@ -1676,6 +1681,7 @@ private data class PlusAddressedEmailHandlers( private data class CatchAllEmailHandlers( val onDomainChange: (String) -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { fun create(viewModel: GeneratorViewModel): CatchAllEmailHandlers { return CatchAllEmailHandlers( @@ -1706,6 +1712,7 @@ private data class RandomWordHandlers( val onCapitalizeChange: (Boolean) -> Unit, val onIncludeNumberChange: (Boolean) -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { fun create(viewModel: GeneratorViewModel): RandomWordHandlers { return RandomWordHandlers( diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt b/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt index cd01eaa82..5a80e451d 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt @@ -1810,6 +1810,7 @@ data class GeneratorState( override val displayStringResId: Int get() = PasscodeTypeOption.PASSWORD.labelRes + @Suppress("UndocumentedPublicClass") companion object { private const val DEFAULT_PASSWORD_LENGTH: Int = 14 private const val MIN_NUMBERS: Int = 1 @@ -1845,6 +1846,7 @@ data class GeneratorState( override val displayStringResId: Int get() = PasscodeTypeOption.PASSPHRASE.labelRes + @Suppress("UndocumentedPublicClass") companion object { private const val DEFAULT_PASSPHRASE_SEPARATOR: Char = '-' private const val DEFAULT_NUM_WORDS: Int = 3 diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/handlers/AddSendHandlers.kt b/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/handlers/AddSendHandlers.kt index ef7523a3b..415425b21 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/handlers/AddSendHandlers.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/handlers/AddSendHandlers.kt @@ -26,6 +26,7 @@ data class AddSendHandlers( val onExpirationDateChange: (ZonedDateTime?) -> Unit, val onClearExpirationDateClick: () -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { /** * Creates an instance of [AddSendHandlers] by binding actions to the provided diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/handlers/SendHandlers.kt b/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/handlers/SendHandlers.kt index 84a6d1caa..512cc4d9b 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/handlers/SendHandlers.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/handlers/SendHandlers.kt @@ -18,6 +18,7 @@ data class SendHandlers( val onDeleteSendClick: (SendState.ViewState.Content.SendItem) -> Unit, val onRemovePasswordClick: (SendState.ViewState.Content.SendItem) -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { /** * Creates an instance of [SendHandlers] by binding actions to the provided [SendViewModel]. diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditCardTypeHandlers.kt b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditCardTypeHandlers.kt index 859dd0fb0..777211b48 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditCardTypeHandlers.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditCardTypeHandlers.kt @@ -30,6 +30,7 @@ data class VaultAddEditCardTypeHandlers( val onSecurityCodeVisibilityChange: (Boolean) -> Unit, val onNumberVisibilityChange: (Boolean) -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { /** diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditCommonHandlers.kt b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditCommonHandlers.kt index ba253a65c..59209ea36 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditCommonHandlers.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditCommonHandlers.kt @@ -39,6 +39,7 @@ data class VaultAddEditCommonHandlers( val onCollectionSelect: (VaultCollection) -> Unit, val onHiddenFieldVisibilityChange: (Boolean) -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { /** diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditIdentityTypeHandlers.kt b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditIdentityTypeHandlers.kt index 842c6d8e1..5ed129125 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditIdentityTypeHandlers.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditIdentityTypeHandlers.kt @@ -46,6 +46,7 @@ data class VaultAddEditIdentityTypeHandlers( val onZipTextChange: (String) -> Unit, val onCountryTextChange: (String) -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { /** diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditLoginTypeHandlers.kt b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditLoginTypeHandlers.kt index 933c0f9e2..11b45622d 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditLoginTypeHandlers.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditLoginTypeHandlers.kt @@ -43,6 +43,7 @@ data class VaultAddEditLoginTypeHandlers( val onPasswordVisibilityChange: (Boolean) -> Unit, val onClearFido2CredentialClick: () -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { /** diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditUserVerificationHandlers.kt b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditUserVerificationHandlers.kt index 892741719..67814c260 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditUserVerificationHandlers.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/handlers/VaultAddEditUserVerificationHandlers.kt @@ -24,6 +24,7 @@ data class VaultAddEditUserVerificationHandlers( val onUserVerificationCancelled: () -> Unit, val onUserVerificationNotSupported: () -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { /** diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/attachments/handlers/AttachmentsHandlers.kt b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/attachments/handlers/AttachmentsHandlers.kt index bd372f11b..a166d1e48 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/attachments/handlers/AttachmentsHandlers.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/attachments/handlers/AttachmentsHandlers.kt @@ -15,6 +15,7 @@ data class AttachmentsHandlers( val onDeleteClick: (attachmentId: String) -> Unit, val onDismissRequest: () -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { /** * Creates the [AttachmentsHandlers] using the [AttachmentsViewModel] to send desired diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultCardItemTypeHandlers.kt b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultCardItemTypeHandlers.kt index 98af99319..690aa7c03 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultCardItemTypeHandlers.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultCardItemTypeHandlers.kt @@ -13,6 +13,7 @@ data class VaultCardItemTypeHandlers( val onShowNumberClick: (Boolean) -> Unit, val onShowSecurityCodeClick: (Boolean) -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { /** diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultCommonItemTypeHandlers.kt b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultCommonItemTypeHandlers.kt index 468720ec0..ec011346e 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultCommonItemTypeHandlers.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultCommonItemTypeHandlers.kt @@ -22,6 +22,7 @@ data class VaultCommonItemTypeHandlers( ) -> Unit, val onAttachmentDownloadClick: (VaultItemState.ViewState.Content.Common.AttachmentItem) -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { /** * Creates an instance of [VaultCommonItemTypeHandlers] by binding actions diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultLoginItemTypeHandlers.kt b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultLoginItemTypeHandlers.kt index bf5ce3ce4..c8b69e51a 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultLoginItemTypeHandlers.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/handlers/VaultLoginItemTypeHandlers.kt @@ -18,6 +18,7 @@ data class VaultLoginItemTypeHandlers( val onPasswordHistoryClick: () -> Unit, val onShowPasswordClick: (isVisible: Boolean) -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { /** * Creates the [VaultLoginItemTypeHandlers] using the [viewModel] to send desired actions. diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/handlers/VaultItemListingHandlers.kt b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/handlers/VaultItemListingHandlers.kt index 82c88c747..fc166c89d 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/handlers/VaultItemListingHandlers.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/handlers/VaultItemListingHandlers.kt @@ -26,6 +26,7 @@ data class VaultItemListingHandlers( val lockClick: () -> Unit, val overflowItemClick: (action: ListingItemOverflowAction) -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { /** * Creates an instance of [VaultItemListingHandlers] by binding actions to the provided diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/handlers/VaultItemListingUserVerificationHandlers.kt b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/handlers/VaultItemListingUserVerificationHandlers.kt index d0b1163b5..387e9b015 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/handlers/VaultItemListingUserVerificationHandlers.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/itemlisting/handlers/VaultItemListingUserVerificationHandlers.kt @@ -21,6 +21,7 @@ data class VaultItemListingUserVerificationHandlers( val onUserVerificationCancelled: () -> Unit, val onUserVerificationNotSupported: (selectedCipherId: String?) -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { /** diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/handlers/VaultHandlers.kt b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/handlers/VaultHandlers.kt index 006f82702..2d06d7dab 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/handlers/VaultHandlers.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/handlers/VaultHandlers.kt @@ -35,6 +35,7 @@ data class VaultHandlers( val overflowOptionClick: (ListingItemOverflowAction.VaultAction) -> Unit, val masterPasswordRepromptSubmit: (ListingItemOverflowAction.VaultAction, String) -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { /** * Creates an instance of [VaultHandlers] by binding actions to the provided diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/verificationcode/handlers/VerificationCodeHandlers.kt b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/verificationcode/handlers/VerificationCodeHandlers.kt index 393fcbc72..1fe376b98 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/verificationcode/handlers/VerificationCodeHandlers.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/verificationcode/handlers/VerificationCodeHandlers.kt @@ -16,6 +16,7 @@ data class VerificationCodeHandlers( val lockClick: () -> Unit, val copyClick: (text: String) -> Unit, ) { + @Suppress("UndocumentedPublicClass") companion object { /** * Creates an instance of [VerificationCodeHandlers] by binding actions to the provided diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/vault/model/VaultLinkedFieldType.kt b/app/src/main/java/com/x8bit/bitwarden/ui/vault/model/VaultLinkedFieldType.kt index 3611622d9..44a5b52bf 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/vault/model/VaultLinkedFieldType.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/vault/model/VaultLinkedFieldType.kt @@ -45,6 +45,7 @@ enum class VaultLinkedFieldType( FULL_NAME(id = 418.toUInt(), label = R.string.full_name.asText()), ; + @Suppress("UndocumentedPublicClass") companion object { /** * Helper function to get the LinkedCustomFieldType from the id diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml index 8640609b1..3c595f901 100644 --- a/gradle/libs.versions.toml +++ b/gradle/libs.versions.toml @@ -26,7 +26,7 @@ androdixAutofill = "1.1.0" androidxWork = "2.9.1" bitwardenSdk = "0.5.0-20240819.160739-177" crashlytics = "3.0.2" -detekt = "1.23.6" +detekt = "1.23.7" firebaseBom = "33.2.0" glide = "1.0.0-beta01" googleServices = "4.4.2"