mirrors/bitwarden-android
1
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2024-12-25 10:28:28 +03:00
Code Issues Projects Releases Packages Wiki Activity

throttle fast type searches

Browse source
This commit is contained in:
Kyle Spearrin 2018-09-24 15:30:05 -04:00
parent 07dd9df3ec
commit f394eddc01
2 changed files with 27 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
src/iOS.Autofill/LoginSearchViewController.cs
View file

@ -8,6 +8,7 @@ using Bit.iOS.Core.Controllers;
using Bit.App.Resources; using Bit.App.Resources;
using Bit.iOS.Core.Views; using Bit.iOS.Core.Views;
using System.Threading; using System.Threading;
using System.Threading.Tasks;
namespace Bit.iOS.Autofill namespace Bit.iOS.Autofill
{ {
@ -163,6 +164,7 @@ namespace Bit.iOS.Autofill
public class SearchDelegate : UISearchBarDelegate public class SearchDelegate : UISearchBarDelegate
{ {
private readonly LoginSearchViewController _controller; private readonly LoginSearchViewController _controller;
private CancellationTokenSource _filterResultsCancellationTokenSource;
public SearchDelegate(LoginSearchViewController controller) public SearchDelegate(LoginSearchViewController controller)
{ {
@ -171,8 +173,28 @@ namespace Bit.iOS.Autofill
public override void TextChanged(UISearchBar searchBar, string searchText) public override void TextChanged(UISearchBar searchBar, string searchText)
{ {
((TableSource)_controller.TableView.Source).FilterResults(searchText, new CancellationToken()); var cts = new CancellationTokenSource();
_controller.TableView.ReloadData(); Task.Run(async () =>
{
if(!string.IsNullOrWhiteSpace(searchText))
{
await Task.Delay(300);
if(searchText != searchBar.Text)
{
return;
}
else
{
_filterResultsCancellationTokenSource?.Cancel();
}
}
try
{
((TableSource)_controller.TableView.Source).FilterResults(searchText, cts.Token);
_controller.TableView.ReloadData();
}
catch(OperationCanceledException) { }
}, cts.Token);
} }
} }
} }

4
src/iOS.Core/Views/ExtensionTableSource.cs
View file

@ -59,7 +59,9 @@ namespace Bit.iOS.Core.Views
combinedLogins.AddRange(logins); combinedLogins.AddRange(logins);
} }
_allItems = combinedLogins.Select(s => new CipherViewModel(s)) _allItems = combinedLogins
.Where(c => c.Type == App.Enums.CipherType.Login)
.Select(s => new CipherViewModel(s))
.OrderBy(s => s.Name) .OrderBy(s => s.Name)
.ThenBy(s => s.Username) .ThenBy(s => s.Username)
.ToList() ?? new List<CipherViewModel>(); .ToList() ?? new List<CipherViewModel>();