mirrors/bitwarden-android
1
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2025-03-15 18:58:59 +03:00
Code Issues Projects Releases Packages Wiki Activity

Disable login button when password is blank (#441)

Browse source
This commit is contained in:
Caleb Derosier 2023-12-28 10:49:15 -06:00 • committed by Álison Fernandes
parent 492038f163
commit e92c85005b
2 changed files with 50 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/login/LoginViewModel.kt
View file

@ -42,7 +42,7 @@ class LoginViewModel @Inject constructor(
initialState = savedStateHandle[KEY_STATE]
?: LoginState(
emailAddress = LoginArgs(savedStateHandle).emailAddress,
isLoginButtonEnabled = true,
isLoginButtonEnabled = false,
passwordInput = "",
environmentLabel = environmentRepository.environment.label,
loadingDialogState = LoadingDialogState.Hidden,
@ -208,7 +208,12 @@ class LoginViewModel @Inject constructor(
}
private fun handlePasswordInputChanged(action: LoginAction.PasswordInputChanged) {
mutableStateFlow.update { it.copy(passwordInput = action.input) }
mutableStateFlow.update {
it.copy(
passwordInput = action.input,
isLoginButtonEnabled = action.input.isNotBlank(),
)
}
}
}

54
app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/login/LoginViewModelTest.kt
View file

@ -343,17 +343,49 @@ class LoginViewModelTest : BaseViewModelTest() {
}
@Test
fun `PasswordInputChanged should update password input`() = runTest {
val input = "input"
val viewModel = createViewModel()
viewModel.eventFlow.test {
viewModel.actionChannel.trySend(LoginAction.PasswordInputChanged(input))
assertEquals(
DEFAULT_STATE.copy(passwordInput = input),
viewModel.stateFlow.value,
)
fun `PasswordInputChanged should update input and enable button if password is not blank`() =
runTest {
val input = "input"
val viewModel = createViewModel()
viewModel.eventFlow.test {
viewModel.actionChannel.trySend(LoginAction.PasswordInputChanged(input))
assertEquals(
DEFAULT_STATE.copy(
passwordInput = input,
isLoginButtonEnabled = true,
),
viewModel.stateFlow.value,
)
}
}
@Test
fun `PasswordInputChanged should update input and disable button if password is blank`() =
runTest {
val input = "input"
val viewModel = createViewModel()
viewModel.eventFlow.test {
// set isLoginButtonEnabled to true
viewModel.actionChannel.trySend(LoginAction.PasswordInputChanged(input))
assertEquals(
DEFAULT_STATE.copy(
passwordInput = input,
isLoginButtonEnabled = true,
),
viewModel.stateFlow.value,
)
// set isLoginButtonEnabled to false
viewModel.actionChannel.trySend(LoginAction.PasswordInputChanged(""))
assertEquals(
DEFAULT_STATE.copy(
passwordInput = "",
isLoginButtonEnabled = false,
),
viewModel.stateFlow.value,
)
}
}
}
@Test
fun `captchaTokenFlow success update should trigger a login`() = runTest {
@ -383,7 +415,7 @@ class LoginViewModelTest : BaseViewModelTest() {
private val DEFAULT_STATE = LoginState(
emailAddress = "test@gmail.com",
passwordInput = "",
isLoginButtonEnabled = true,
isLoginButtonEnabled = false,
environmentLabel = Environment.Us.label,
loadingDialogState = LoadingDialogState.Hidden,
errorDialogState = BasicDialogState.Hidden,