mirrors/bitwarden-android
1
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2024-10-31 07:05:35 +03:00
Code Issues Projects Releases Packages Wiki Activity

Remove unused Json object from VaultRepository (#3653)
Some checks failed
Crowdin Push / Crowdin Push (push) Waiting to run
Scan / Check PR run (push) Failing after 0s
Scan / SAST scan (push) Has been skipped
Scan / Quality scan (push) Has been skipped
Test / Check PR run (push) Failing after 0s
Test / Test (push) Has been skipped

Browse source
This commit is contained in:
David Perez 2024-07-30 17:44:05 -05:00 committed by GitHub
parent 6d22ee9550
commit d5e0ebee12
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 0 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt
View file

@ -108,7 +108,6 @@ import kotlinx.coroutines.flow.onStart
import kotlinx.coroutines.flow.stateIn
import kotlinx.coroutines.flow.update
import kotlinx.coroutines.launch
import kotlinx.serialization.json.Json
import retrofit2.HttpException
import java.time.Clock
import java.time.temporal.ChronoUnit
@ -139,7 +138,6 @@ class VaultRepositoryImpl(
private val userLogoutManager: UserLogoutManager,
pushManager: PushManager,
private val clock: Clock,
private val json: Json,
dispatcherManager: DispatcherManager,
) : VaultRepository,
CipherManager by cipherManager,

3
app/src/main/java/com/x8bit/bitwarden/data/vault/repository/di/VaultRepositoryModule.kt
View file

@ -21,7 +21,6 @@ import dagger.Module
import dagger.Provides
import dagger.hilt.InstallIn
import dagger.hilt.components.SingletonComponent
import kotlinx.serialization.json.Json
import java.time.Clock
import javax.inject.Singleton
@ -51,7 +50,6 @@ object VaultRepositoryModule {
pushManager: PushManager,
userLogoutManager: UserLogoutManager,
clock: Clock,
json: Json,
): VaultRepository = VaultRepositoryImpl(
syncService = syncService,
sendsService = sendsService,
@ -69,6 +67,5 @@ object VaultRepositoryModule {
pushManager = pushManager,
userLogoutManager = userLogoutManager,
clock = clock,
json = json,
)
}

4
app/src/test/java/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryTest.kt
View file

@ -25,7 +25,6 @@ import com.x8bit.bitwarden.data.auth.manager.UserLogoutManager
import com.x8bit.bitwarden.data.auth.repository.util.toSdkParams
import com.x8bit.bitwarden.data.platform.base.FakeDispatcherManager
import com.x8bit.bitwarden.data.platform.datasource.disk.SettingsDiskSource
import com.x8bit.bitwarden.data.platform.datasource.network.di.PlatformNetworkModule
import com.x8bit.bitwarden.data.platform.manager.PushManager
import com.x8bit.bitwarden.data.platform.manager.dispatcher.DispatcherManager
import com.x8bit.bitwarden.data.platform.manager.model.SyncCipherDeleteData
@ -117,7 +116,6 @@ import kotlinx.coroutines.flow.first
import kotlinx.coroutines.flow.flowOf
import kotlinx.coroutines.flow.update
import kotlinx.coroutines.test.runTest
import kotlinx.serialization.json.Json
import org.junit.jupiter.api.AfterEach
import org.junit.jupiter.api.Assertions.assertEquals
import org.junit.jupiter.api.Assertions.assertTrue
@ -140,7 +138,6 @@ class VaultRepositoryTest {
Instant.parse("2023-10-27T12:00:00Z"),
ZoneOffset.UTC,
)
private val json: Json = PlatformNetworkModule.providesJson()
private val dispatcherManager: DispatcherManager = FakeDispatcherManager()
private val userLogoutManager: UserLogoutManager = mockk {
every { logout(any(), any()) } just runs
@ -226,7 +223,6 @@ class VaultRepositoryTest {
fileManager = fileManager,
clock = clock,
userLogoutManager = userLogoutManager,
json = json,
)
@BeforeEach