From c47f8606cd90edf0e811a1e739ddbcb6bee4c809 Mon Sep 17 00:00:00 2001 From: ifernandezdiaz Date: Mon, 28 Oct 2024 11:28:07 -0300 Subject: [PATCH] QA-953: Adding testTag to elements in Add TOTP screen (#4160) --- .../feature/manualcodeentry/ManualCodeEntryScreen.kt | 12 +++++++++--- .../ui/vault/feature/qrcodescan/QrCodeScanScreen.kt | 2 ++ 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/manualcodeentry/ManualCodeEntryScreen.kt b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/manualcodeentry/ManualCodeEntryScreen.kt index a022618c4..9fff98335 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/manualcodeentry/ManualCodeEntryScreen.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/manualcodeentry/ManualCodeEntryScreen.kt @@ -23,6 +23,7 @@ import androidx.compose.runtime.saveable.rememberSaveable import androidx.compose.runtime.setValue import androidx.compose.ui.Modifier import androidx.compose.ui.platform.LocalContext +import androidx.compose.ui.platform.testTag import androidx.compose.ui.res.stringResource import androidx.compose.ui.unit.dp import androidx.hilt.navigation.compose.hiltViewModel @@ -126,7 +127,9 @@ fun ManualCodeEntryScreen( Text( text = stringResource(id = R.string.enter_key_manually), style = BitwardenTheme.typography.titleMedium, - modifier = Modifier.padding(horizontal = 16.dp), + modifier = Modifier + .padding(horizontal = 16.dp) + .testTag("EnterKeyManuallyButton"), ) Spacer(modifier = Modifier.height(8.dp)) @@ -143,7 +146,8 @@ fun ManualCodeEntryScreen( }, modifier = Modifier .fillMaxWidth() - .padding(horizontal = 16.dp), + .padding(horizontal = 16.dp) + .testTag("AddManualTOTPField"), ) Spacer(modifier = Modifier.height(16.dp)) @@ -154,7 +158,8 @@ fun ManualCodeEntryScreen( }, modifier = Modifier .fillMaxWidth() - .padding(horizontal = 16.dp), + .padding(horizontal = 16.dp) + .testTag("AddManualTOTPButton"), ) Text( @@ -191,6 +196,7 @@ fun ManualCodeEntryScreen( } }, style = BitwardenTheme.typography.bodyMedium, + modifier = Modifier.testTag("ScanQRCodeButton"), ) } } diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/qrcodescan/QrCodeScanScreen.kt b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/qrcodescan/QrCodeScanScreen.kt index db4307cf1..2e14935b9 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/qrcodescan/QrCodeScanScreen.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/qrcodescan/QrCodeScanScreen.kt @@ -44,6 +44,7 @@ import androidx.compose.ui.graphics.drawscope.drawIntoCanvas import androidx.compose.ui.graphics.nativeCanvas import androidx.compose.ui.platform.LocalConfiguration import androidx.compose.ui.platform.LocalContext +import androidx.compose.ui.platform.testTag import androidx.compose.ui.res.stringResource import androidx.compose.ui.text.style.TextAlign import androidx.compose.ui.unit.Dp @@ -426,6 +427,7 @@ private fun BottomClickableText( style = BitwardenTheme.typography.labelLarge, innerPadding = PaddingValues(vertical = 4.dp, horizontal = 12.dp), onClick = onEnterCodeManuallyClick, + modifier = Modifier.testTag("EnterKeyManuallyButton"), ) } }