mirrors/bitwarden-android
1
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2025-02-17 04:19:54 +03:00
Code Issues Projects Releases Packages Wiki Activity

BIT-748: Settings about, rate app (#765)

Browse source
This commit is contained in:
Joshua Queen 2024-01-24 21:24:24 -05:00 • committed by Álison Fernandes
parent 84346e2b29
commit c2e6497fd8
4 changed files with 20 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutScreen.kt
View file

@ -1,6 +1,5 @@
package com.x8bit.bitwarden.ui.platform.feature.settings.about
import android.widget.Toast
import androidx.compose.foundation.clickable
import androidx.compose.foundation.interaction.MutableInteractionSource
import androidx.compose.foundation.layout.Arrangement
@ -81,8 +80,11 @@ fun AboutScreen(
intentManager.launchUri("https://vault.bitwarden.com".toUri())
}
is AboutEvent.ShowToast -> {
Toast.makeText(context, event.text(resources), Toast.LENGTH_SHORT).show()
AboutEvent.NavigateToRateApp -> {
intentManager.launchUri(
uri =
"https://play.google.com/store/apps/details?id=com.x8bit.bitwarden".toUri(),
)
}
}
}

9
app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutViewModel.kt
View file

@ -58,8 +58,7 @@ class AboutViewModel @Inject constructor(
}
private fun handleRateAppClick() {
// TODO: BIT-748 Launch the rate your app UI.
sendEvent(AboutEvent.ShowToast(text = "Navigate to rate the app.".asText()))
sendEvent(AboutEvent.NavigateToRateApp)
}
private fun handleSubmitCrashLogsClick(action: AboutAction.SubmitCrashLogsClick) {
@ -120,11 +119,9 @@ sealed class AboutEvent {
data object NavigateToWebVault : AboutEvent()
/**
* Displays a toast with the given [Text].
* Navigates to rate the app.
*/
data class ShowToast(
val text: Text,
) : AboutEvent()
data object NavigateToRateApp : AboutEvent()
}
/**

10
app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutScreenTest.kt
View file

@ -142,6 +142,16 @@ class AboutScreenTest : BaseComposeTest() {
}
}
@Test
fun `on NavigateToAboutSend should call launchUri on intentManager`() {
mutableEventFlow.tryEmit(AboutEvent.NavigateToRateApp)
verify {
intentManager.launchUri(
"https://play.google.com/store/apps/details?id=com.x8bit.bitwarden".toUri(),
)
}
}
@Suppress("MaxLineLength")
@Test
fun `on rate the app click should display confirmation dialog and confirm click should emit RateAppClick`() {

4
app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutViewModelTest.kt
View file

@ -49,11 +49,11 @@ class AboutViewModelTest : BaseViewModelTest() {
}
@Test
fun `on RateAppClick should emit ShowToast`() = runTest {
fun `on RateAppClick should emit NavigateToRateApp`() = runTest {
val viewModel = createViewModel(DEFAULT_ABOUT_STATE)
viewModel.eventFlow.test {
viewModel.trySendAction(AboutAction.RateAppClick)
assertEquals(AboutEvent.ShowToast("Navigate to rate the app.".asText()), awaitItem())
assertEquals(AboutEvent.NavigateToRateApp, awaitItem())
}
}