[PM-10670] Prompt for PIN creation during passkey user verification (#3694)

This commit is contained in:
Patrick Honkonen 2024-08-07 14:17:13 -04:00 committed by GitHub
parent 782b474e54
commit be534f940b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 2 deletions

View file

@ -10,7 +10,6 @@ import com.x8bit.bitwarden.R
import com.x8bit.bitwarden.data.auth.repository.AuthRepository
import com.x8bit.bitwarden.data.auth.repository.model.ValidatePasswordResult
import com.x8bit.bitwarden.data.auth.repository.model.ValidatePinResult
import com.x8bit.bitwarden.data.auth.repository.model.VaultUnlockType
import com.x8bit.bitwarden.data.autofill.fido2.manager.Fido2CredentialManager
import com.x8bit.bitwarden.data.autofill.fido2.model.Fido2CredentialAssertionRequest
import com.x8bit.bitwarden.data.autofill.fido2.model.Fido2CredentialAssertionResult
@ -370,7 +369,7 @@ class VaultItemListingViewModel @Inject constructor(
return
}
if (activeAccount.vaultUnlockType == VaultUnlockType.PIN) {
if (settingsRepository.isUnlockWithPinEnabled) {
mutableStateFlow.update {
it.copy(
dialogState = VaultItemListingState.DialogState.Fido2PinPrompt(

View file

@ -141,6 +141,7 @@ class VaultItemListingViewModelTest : BaseViewModelTest() {
every { isIconLoadingDisabled } returns false
every { isIconLoadingDisabledFlow } returns mutableIsIconLoadingDisabledFlow
every { getPullToRefreshEnabledFlow() } returns mutablePullToRefreshEnabledFlow
every { isUnlockWithPinEnabled } returns false
}
private val specialCircumstanceManager = SpecialCircumstanceManagerImpl()
private val policyManager: PolicyManager = mockk {
@ -3107,6 +3108,7 @@ class VaultItemListingViewModelTest : BaseViewModelTest() {
),
),
)
every { settingsRepository.isUnlockWithPinEnabled } returns true
viewModel.trySendAction(
VaultItemListingsAction.UserVerificationNotSupported(