mirrors/bitwarden-android
1
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2025-01-28 02:33:44 +03:00
Code Issues Projects Releases Packages Wiki Activity

Disable LandingScreen Continue button until data is entered (#89)

Browse source
This commit is contained in:
Brian Yencho 2023-10-03 14:38:02 -05:00 • committed by Álison Fernandes
parent 9fe145d75d
commit bac5e4e030
3 changed files with 65 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModel.kt
View file

@ -23,7 +23,7 @@ class LandingViewModel @Inject constructor(
initialState = savedStateHandle[KEY_STATE]
?: LandingState(
emailInput = "",
isContinueButtonEnabled = true,
isContinueButtonEnabled = false,
isRememberMeEnabled = false,
),
) {
@ -45,7 +45,13 @@ class LandingViewModel @Inject constructor(
}
private fun handleEmailInputUpdated(action: LandingAction.EmailInputChanged) {
mutableStateFlow.update { it.copy(emailInput = action.input) }
val email = action.input
mutableStateFlow.update {
it.copy(
emailInput = email,
isContinueButtonEnabled = email.isNotBlank(),
)
}
}
private fun handleContinueButtonClicked() {

29
app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingScreenTest.kt
View file

@ -1,5 +1,7 @@
package com.x8bit.bitwarden.ui.auth.feature.landing
import androidx.compose.ui.test.assertIsEnabled
import androidx.compose.ui.test.assertIsNotEnabled
import androidx.compose.ui.test.filterToOne
import androidx.compose.ui.test.hasClickAction
import androidx.compose.ui.test.onChildren
@ -14,10 +16,37 @@ import io.mockk.verify
import kotlinx.coroutines.flow.MutableStateFlow
import kotlinx.coroutines.flow.emptyFlow
import kotlinx.coroutines.flow.flowOf
import kotlinx.coroutines.flow.update
import org.junit.Test
import org.junit.jupiter.api.Assertions.assertEquals
class LandingScreenTest : BaseComposeTest() {
@Test
fun `continue button should be enabled or disabled according to the state`() {
val mutableStateFlow = MutableStateFlow(
LandingState(
emailInput = "",
isContinueButtonEnabled = true,
isRememberMeEnabled = false,
),
)
val viewModel = mockk<LandingViewModel>(relaxed = true) {
every { eventFlow } returns emptyFlow()
every { stateFlow } returns mutableStateFlow
}
composeTestRule.setContent {
LandingScreen(
onNavigateToCreateAccount = {},
onNavigateToLogin = {},
viewModel = viewModel,
)
}
composeTestRule.onNodeWithText("Continue").assertIsEnabled()
mutableStateFlow.update { it.copy(isContinueButtonEnabled = false) }
composeTestRule.onNodeWithText("Continue").assertIsNotEnabled()
}
@Test
fun `continue button click should send ContinueButtonClick action`() {

40
app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/landing/LandingViewModelTest.kt
View file

@ -77,23 +77,39 @@ class LandingViewModelTest : BaseViewModelTest() {
}
@Test
fun `EmailInputUpdated should update value of email input`() = runTest {
val input = "input"
val viewModel = LandingViewModel(SavedStateHandle())
viewModel.stateFlow.test {
awaitItem()
viewModel.trySendAction(LandingAction.EmailInputChanged(input))
assertEquals(
DEFAULT_STATE.copy(emailInput = input),
awaitItem(),
)
fun `EmailInputUpdated should update value of email input and continue button state`() =
runTest {
val viewModel = LandingViewModel(SavedStateHandle())
viewModel.stateFlow.test {
// Ignore initial state
awaitItem()
val nonEmptyInput = "input"
viewModel.trySendAction(LandingAction.EmailInputChanged(nonEmptyInput))
assertEquals(
DEFAULT_STATE.copy(
emailInput = nonEmptyInput,
isContinueButtonEnabled = true,
),
awaitItem(),
)
val emptyInput = ""
viewModel.trySendAction(LandingAction.EmailInputChanged(emptyInput))
assertEquals(
DEFAULT_STATE.copy(
emailInput = emptyInput,
isContinueButtonEnabled = false,
),
awaitItem(),
)
}
}
}
companion object {
private val DEFAULT_STATE = LandingState(
emailInput = "",
isContinueButtonEnabled = true,
isContinueButtonEnabled = false,
isRememberMeEnabled = false,
)
}