mirrors/bitwarden-android
1
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2025-02-18 04:50:01 +03:00
Code Issues Projects Releases Packages Wiki Activity

Display SDK error message when generating email alias (#1219)

Browse source
This commit is contained in:
Patrick Honkonen 2024-04-03 17:29:21 -04:00 • committed by Álison Fernandes
parent 22a6825992
commit af37f1c03c
4 changed files with 13 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/com/x8bit/bitwarden/data/tools/generator/repository/GeneratorRepositoryImpl.kt
View file

@ -200,7 +200,7 @@ class GeneratorRepositoryImpl(
GeneratedForwardedServiceUsernameResult.Success(generatedEmail) GeneratedForwardedServiceUsernameResult.Success(generatedEmail)
}, },
onFailure = { onFailure = {
GeneratedForwardedServiceUsernameResult.InvalidRequest GeneratedForwardedServiceUsernameResult.InvalidRequest(it.message)
}, },
) )

2
app/src/main/java/com/x8bit/bitwarden/data/tools/generator/repository/model/GeneratedForwardedServiceUsernameResult.kt
View file

@ -14,5 +14,5 @@ sealed class GeneratedForwardedServiceUsernameResult {
/** /**
* There was an error during the operation. * There was an error during the operation.
*/ */
data object InvalidRequest : GeneratedForwardedServiceUsernameResult() data class InvalidRequest(val message: String?) : GeneratedForwardedServiceUsernameResult()
} }

9
app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt
View file

@ -651,8 +651,13 @@ class GeneratorViewModel @Inject constructor(
} }
} }
GeneratedForwardedServiceUsernameResult.InvalidRequest -> { is GeneratedForwardedServiceUsernameResult.InvalidRequest -> {
sendEvent(GeneratorEvent.ShowSnackbar(R.string.an_error_has_occurred.asText())) sendEvent(
GeneratorEvent.ShowSnackbar(
message = result.message?.asText()
?: R.string.an_error_has_occurred.asText(),
),
)
} }
} }
} }

5
app/src/test/java/com/x8bit/bitwarden/data/tools/generator/repository/GeneratorRepositoryTest.kt
View file

@ -410,7 +410,10 @@ class GeneratorRepositoryTest {
val result = repository.generateForwardedServiceUsername(request) val result = repository.generateForwardedServiceUsername(request)
assertEquals(GeneratedForwardedServiceUsernameResult.InvalidRequest, result) assertEquals(
GeneratedForwardedServiceUsernameResult.InvalidRequest(exception.message),
result,
)
coVerify { generatorSdkSource.generateForwardedServiceEmail(request) } coVerify { generatorSdkSource.generateForwardedServiceEmail(request) }
} }