From ace5f193753095559d3b29f13fa74ffda458e305 Mon Sep 17 00:00:00 2001 From: Wu Nan Date: Mon, 26 Aug 2024 22:58:19 +0800 Subject: [PATCH] [PM-11307] Fix typo in method name: shouldShouldRequestPermissionRationale (#3821) --- .../ui/platform/manager/permissions/PermissionsManager.kt | 2 +- .../ui/platform/manager/permissions/PermissionsManagerImpl.kt | 2 +- .../ui/platform/manager/permissions/FakePermissionManager.kt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/permissions/PermissionsManager.kt b/app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/permissions/PermissionsManager.kt index c8ffed65f..21dece6b2 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/permissions/PermissionsManager.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/permissions/PermissionsManager.kt @@ -39,7 +39,7 @@ interface PermissionsManager { /** * Method for checking if an informative UI should be shown the user. */ - fun shouldShouldRequestPermissionRationale( + fun shouldShowRequestPermissionRationale( permission: String, ): Boolean } diff --git a/app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/permissions/PermissionsManagerImpl.kt b/app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/permissions/PermissionsManagerImpl.kt index be13a8799..692d73c0b 100644 --- a/app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/permissions/PermissionsManagerImpl.kt +++ b/app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/permissions/PermissionsManagerImpl.kt @@ -44,7 +44,7 @@ class PermissionsManagerImpl( override fun checkPermissions(permissions: Array): Boolean = permissions.map { checkPermission(it) }.all { isGranted -> isGranted } - override fun shouldShouldRequestPermissionRationale( + override fun shouldShowRequestPermissionRationale( permission: String, ): Boolean = activity.shouldShowRequestPermissionRationale(permission) diff --git a/app/src/test/java/com/x8bit/bitwarden/ui/platform/manager/permissions/FakePermissionManager.kt b/app/src/test/java/com/x8bit/bitwarden/ui/platform/manager/permissions/FakePermissionManager.kt index 842660f62..a9f058c67 100644 --- a/app/src/test/java/com/x8bit/bitwarden/ui/platform/manager/permissions/FakePermissionManager.kt +++ b/app/src/test/java/com/x8bit/bitwarden/ui/platform/manager/permissions/FakePermissionManager.kt @@ -62,7 +62,7 @@ class FakePermissionManager : PermissionsManager { return checkPermissionResult } - override fun shouldShouldRequestPermissionRationale( + override fun shouldShowRequestPermissionRationale( permission: String, ): Boolean { return shouldShowRequestRationale