mirrors/bitwarden-android
1
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2024-10-31 15:15:34 +03:00
Code Issues Projects Releases Packages Wiki Activity

Expose the HaveIBeenPwned service via auth repo (#306)

Browse source
This commit is contained in:
David Perez 2023-11-30 15:19:47 -06:00 committed by Álison Fernandes
parent c377376835
commit aad143c9b6
4 changed files with 63 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepository.kt
View file

@ -1,6 +1,7 @@
package com.x8bit.bitwarden.data.auth.repository
import com.x8bit.bitwarden.data.auth.repository.model.AuthState
import com.x8bit.bitwarden.data.auth.repository.model.BreachCountResult
import com.x8bit.bitwarden.data.auth.repository.model.DeleteAccountResult
import com.x8bit.bitwarden.data.auth.repository.model.LoginResult
import com.x8bit.bitwarden.data.auth.repository.model.PasswordStrengthResult
@ -81,6 +82,11 @@ interface AuthRepository : AuthenticatorProvider {
*/
fun setCaptchaCallbackTokenResult(tokenResult: CaptchaCallbackTokenResult)
/**
* Attempts to get the number of times the given [password] has been breached.
*/
suspend fun getPasswordBreachCount(password: String): BreachCountResult
/**
* Get the password strength for the given [email] and [password] combo.
*/

9
app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt
View file

@ -15,6 +15,7 @@ import com.x8bit.bitwarden.data.auth.datasource.sdk.AuthSdkSource
import com.x8bit.bitwarden.data.auth.datasource.sdk.model.PasswordStrength
import com.x8bit.bitwarden.data.auth.datasource.sdk.util.toKdfTypeJson
import com.x8bit.bitwarden.data.auth.repository.model.AuthState
import com.x8bit.bitwarden.data.auth.repository.model.BreachCountResult
import com.x8bit.bitwarden.data.auth.repository.model.DeleteAccountResult
import com.x8bit.bitwarden.data.auth.repository.model.LoginResult
import com.x8bit.bitwarden.data.auth.repository.model.PasswordStrengthResult
@ -337,6 +338,14 @@ class AuthRepositoryImpl constructor(
mutableCaptchaTokenFlow.tryEmit(tokenResult)
}
override suspend fun getPasswordBreachCount(password: String): BreachCountResult =
haveIBeenPwnedService
.getPasswordBreachCount(password)
.fold(
onFailure = { BreachCountResult.Error },
onSuccess = { BreachCountResult.Success(it) },
)
@Suppress("MagicNumber")
override suspend fun getPasswordStrength(
email: String,

16
app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/BreachCountResult.kt Normal file
View file

@ -0,0 +1,16 @@
package com.x8bit.bitwarden.data.auth.repository.model
/**
* Models result of determining if a password has been breached.
*/
sealed class BreachCountResult {
/**
* Contains the number of breaches.
*/
data class Success(val breachCount: Int) : BreachCountResult()
/**
* There was an error determining if the password has been breached.
*/
data object Error : BreachCountResult()
}

32
app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt
View file

@ -25,6 +25,7 @@ import com.x8bit.bitwarden.data.auth.datasource.sdk.model.PasswordStrength.LEVEL
import com.x8bit.bitwarden.data.auth.datasource.sdk.model.PasswordStrength.LEVEL_3
import com.x8bit.bitwarden.data.auth.datasource.sdk.model.PasswordStrength.LEVEL_4
import com.x8bit.bitwarden.data.auth.repository.model.AuthState
import com.x8bit.bitwarden.data.auth.repository.model.BreachCountResult
import com.x8bit.bitwarden.data.auth.repository.model.DeleteAccountResult
import com.x8bit.bitwarden.data.auth.repository.model.LoginResult
import com.x8bit.bitwarden.data.auth.repository.model.PasswordStrengthResult
@ -1078,6 +1079,37 @@ class AuthRepositoryTest {
}
}
@Test
fun `getPasswordBreachCount should return failure when service returns failure`() = runTest {
val password = "password"
coEvery {
haveIBeenPwnedService.getPasswordBreachCount(password)
} returns Throwable("Fail").asFailure()
val result = repository.getPasswordBreachCount(password)
coVerify(exactly = 1) {
haveIBeenPwnedService.getPasswordBreachCount(password)
}
assertEquals(BreachCountResult.Error, result)
}
@Test
fun `getPasswordBreachCount should return success when service returns success`() = runTest {
val password = "password"
val breachCount = 5
coEvery {
haveIBeenPwnedService.getPasswordBreachCount(password)
} returns breachCount.asSuccess()
val result = repository.getPasswordBreachCount(password)
coVerify(exactly = 1) {
haveIBeenPwnedService.getPasswordBreachCount(password)
}
assertEquals(BreachCountResult.Success(breachCount), result)
}
@Test
fun `getPasswordStrength should be based on password length`() = runTest {
// TODO: Replace with SDK call (BIT-964)