mirrors/bitwarden-android
1
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2025-03-15 18:58:59 +03:00
Code Issues Projects Releases Packages Wiki Activity

Add 'Device-Identifier' header for auth-requests API (#1174)

Browse source
This commit is contained in:
David Perez 2024-03-26 11:23:51 -05:00 • committed by Álison Fernandes
parent f8ed3f9084
commit 9144bae079
3 changed files with 13 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/api/UnauthenticatedAuthRequestsApi.kt
View file

@ -4,6 +4,7 @@ import com.x8bit.bitwarden.data.auth.datasource.network.model.AuthRequestRequest
import com.x8bit.bitwarden.data.auth.datasource.network.model.AuthRequestsResponseJson
import retrofit2.http.Body
import retrofit2.http.GET
import retrofit2.http.Header
import retrofit2.http.POST
import retrofit2.http.Path
import retrofit2.http.Query
@ -18,6 +19,7 @@ interface UnauthenticatedAuthRequestsApi {
*/
@POST("/auth-requests")
suspend fun createAuthRequest(
@Header("Device-Identifier") deviceIdentifier: String,
@Body body: AuthRequestRequestJson,
): Result<AuthRequestsResponseJson.AuthRequest>

3
app/src/main/java/com/x8bit/bitwarden/data/auth/datasource/network/service/NewAuthRequestServiceImpl.kt
View file

@ -19,7 +19,8 @@ class NewAuthRequestServiceImpl(
fingerprint: String,
): Result<AuthRequestsResponseJson.AuthRequest> =
unauthenticatedAuthRequestsApi.createAuthRequest(
AuthRequestRequestJson(
deviceIdentifier = deviceId,
body = AuthRequestRequestJson(
email = email,
publicKey = publicKey,
deviceId = deviceId,

13
app/src/test/java/com/x8bit/bitwarden/data/auth/datasource/network/service/NewAuthRequestServiceTest.kt
View file

@ -3,6 +3,7 @@ package com.x8bit.bitwarden.data.auth.datasource.network.service
import com.x8bit.bitwarden.data.auth.datasource.network.api.UnauthenticatedAuthRequestsApi
import com.x8bit.bitwarden.data.auth.datasource.network.model.AuthRequestsResponseJson
import com.x8bit.bitwarden.data.platform.base.BaseServiceTest
import com.x8bit.bitwarden.data.platform.util.asSuccess
import kotlinx.coroutines.test.runTest
import okhttp3.mockwebserver.MockResponse
import org.junit.jupiter.api.Assertions.assertEquals
@ -22,13 +23,15 @@ class NewAuthRequestServiceTest : BaseServiceTest() {
fun `createAuthRequest when request response is Failure should return Failure`() = runTest {
val response = MockResponse().setResponseCode(400)
server.enqueue(response)
val deviceIdentifier = "4321"
val actual = service.createAuthRequest(
email = "test@gmail.com",
publicKey = "1234",
deviceId = "4321",
deviceId = deviceIdentifier,
accessCode = "accessCode",
fingerprint = "fingerprint",
)
assertEquals(deviceIdentifier, server.takeRequest().getHeader("Device-Identifier"))
assertTrue(actual.isFailure)
}
@ -36,14 +39,16 @@ class NewAuthRequestServiceTest : BaseServiceTest() {
fun `createAuthRequest when request response is Success should return Success`() = runTest {
val response = MockResponse().setBody(AUTH_REQUEST_RESPONSE_JSON).setResponseCode(200)
server.enqueue(response)
val deviceIdentifier = "4321"
val actual = service.createAuthRequest(
email = "test@gmail.com",
publicKey = "1234",
deviceId = "4321",
deviceId = deviceIdentifier,
accessCode = "accessCode",
fingerprint = "fingerprint",
)
assertEquals(Result.success(AUTH_REQUEST_RESPONSE), actual)
assertEquals(deviceIdentifier, server.takeRequest().getHeader("Device-Identifier"))
assertEquals(AUTH_REQUEST_RESPONSE.asSuccess(), actual)
}
@Test
@ -65,7 +70,7 @@ class NewAuthRequestServiceTest : BaseServiceTest() {
requestId = "1",
accessCode = "accessCode",
)
assertEquals(Result.success(AUTH_REQUEST_RESPONSE), actual)
assertEquals(AUTH_REQUEST_RESPONSE.asSuccess(), actual)
}
}