mirrors/bitwarden-android
1
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2025-03-16 03:08:50 +03:00
Code Issues Projects Releases Packages Wiki Activity

BIT-2207: Remove Rate the App row (#1228)

Browse source 
Co-authored-by: David Perez <david@livefront.com>
This commit is contained in:
Caleb Derosier 2024-04-04 16:07:49 -06:00 • committed by Álison Fernandes
parent 3d8bf0da31
commit 8f3f87a333
2 changed files with 0 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutScreen.kt
View file

@ -210,12 +210,6 @@ private fun ContentColumn(
id = R.string.learn_about_organizations_description_long,
),
)
BitwardenExternalLinkRow(
text = stringResource(id = R.string.rate_the_app),
onConfirmClick = onRateTheAppClick,
dialogTitle = stringResource(id = R.string.continue_to_app_store),
dialogMessage = stringResource(id = R.string.rate_app_description_long),
)
BitwardenExternalLinkRow(
text = stringResource(R.string.give_feedback),
onConfirmClick = onGiveFeedbackClick,

16
app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/about/AboutScreenTest.kt
View file

@ -201,22 +201,6 @@ class AboutScreenTest : BaseComposeTest() {
}
}
@Suppress("MaxLineLength")
@Test
fun `on rate the app click should display confirmation dialog and confirm click should emit RateAppClick`() {
composeTestRule.onNode(isDialog()).assertDoesNotExist()
composeTestRule.onNodeWithText("Rate the app").performClick()
composeTestRule.onNode(isDialog()).assertExists()
composeTestRule
.onAllNodesWithText("Continue")
.filterToOne(hasAnyAncestor(isDialog()))
.performClick()
composeTestRule.onNode(isDialog()).assertDoesNotExist()
verify {
viewModel.trySendAction(AboutAction.RateAppClick)
}
}
@Test
fun `submit crash logs switch should be displayed according to state`() {
mutableStateFlow.update { it.copy(shouldShowCrashLogsButton = true) }