null and length check on name when sorting

This commit is contained in:
Kyle Spearrin 2018-01-25 21:20:45 -05:00
parent 8b6d2d2b83
commit 8cd3a21468
2 changed files with 8 additions and 5 deletions

View file

@ -23,7 +23,7 @@ namespace Bit.App.Models.Page
if(string.IsNullOrWhiteSpace(Name) || Name.Length == 0)
{
NameGroup = AppResources.Other;
NameGroup = "-";
}
else if(Char.IsLetter(Name[0]))
{
@ -35,7 +35,7 @@ namespace Bit.App.Models.Page
}
else
{
NameGroup = AppResources.Other;
NameGroup = "-";
}
switch(cipher.Type)

View file

@ -341,9 +341,12 @@ namespace Bit.App.Pages
.Select(s => new Cipher(s, _appSettingsService))
.OrderBy(s =>
{
// Sort numbers and letters before special characters
return !string.IsNullOrWhiteSpace(s.Name) && s.Name.Length > 0 &&
Char.IsDigit(s.Name[0]) ? 0 : (Char.IsLetter(s.Name[0]) ? 1 : 2);
if(string.IsNullOrWhiteSpace(s.Name))
{
return 2;
}
return s.Name.Length > 0 && Char.IsDigit(s.Name[0]) ? 0 : (Char.IsLetter(s.Name[0]) ? 1 : 2);
})
.ThenBy(s => s.Name)
.ThenBy(s => s.Subtitle)