minor change (public to private fields)

This commit is contained in:
Dinis Vieira 2023-12-14 22:43:50 +00:00
parent 90912977c4
commit 8b3c6ab35f
No known key found for this signature in database
GPG key ID: 9389160FF6C295F3

View file

@ -75,8 +75,9 @@ namespace Bit.App
} }
public static Window CurrentWindow { get; private set; } public static Window CurrentWindow { get; private set; }
public static Window AutofillWindow { get; private set; }
public static Window MainWindow { get; private set; } private Window _autofillWindow;
private Window _mainWindow;
public void SetOptions(AppOptions appOptions) public void SetOptions(AppOptions appOptions)
{ {
@ -94,21 +95,21 @@ namespace Bit.App
} }
else if (Options.FromAutofillFramework || Options.Uri != null || Options.OtpData != null || Options.CreateSend != null) //"Internal" Autofill and Uri/Otp/CreateSend else if (Options.FromAutofillFramework || Options.Uri != null || Options.OtpData != null || Options.CreateSend != null) //"Internal" Autofill and Uri/Otp/CreateSend
{ {
AutofillWindow = new Window(new NavigationPage(new AndroidExtSplashPage(Options))); _autofillWindow = new Window(new NavigationPage(new AndroidExtSplashPage(Options)));
CurrentWindow = AutofillWindow; CurrentWindow = _autofillWindow;
return CurrentWindow; return CurrentWindow;
} }
else if(CurrentWindow != null) else if(CurrentWindow != null)
{ {
//TODO: This likely crashes if we try to have two apps side-by-side on Android //TODO: This likely crashes if we try to have two apps side-by-side on Android
//TODO: Question: In these scenarios should a new Window be created or can the same one be reused? //TODO: Question: In these scenarios should a new Window be created or can the same one be reused?
CurrentWindow = MainWindow; CurrentWindow = _mainWindow;
return CurrentWindow; return CurrentWindow;
} }
else else
{ {
MainWindow = new Window(new NavigationPage(new HomePage(Options))); _mainWindow = new Window(new NavigationPage(new HomePage(Options)));
CurrentWindow = MainWindow; CurrentWindow = _mainWindow;
return CurrentWindow; return CurrentWindow;
} }
} }