From 8b2471c128925430690ab637ed247d7162e74b27 Mon Sep 17 00:00:00 2001
From: Kyle Spearrin <kyle.spearrin@gmail.com>
Date: Wed, 29 Nov 2017 09:20:45 -0500
Subject: [PATCH] rename features to options

---
 src/App/App.csproj                               |  2 +-
 ...ngsFeaturesPage.cs => SettingsOptionsPage.cs} |  6 +++---
 src/App/Pages/Settings/SettingsPage.cs           | 16 ++++++++--------
 src/App/Resources/AppResources.Designer.cs       |  9 ---------
 src/App/Resources/AppResources.resx              |  3 ---
 5 files changed, 12 insertions(+), 24 deletions(-)
 rename src/App/Pages/Settings/{SettingsFeaturesPage.cs => SettingsOptionsPage.cs} (99%)

diff --git a/src/App/App.csproj b/src/App/App.csproj
index e1beb971c..d429ad9ae 100644
--- a/src/App/App.csproj
+++ b/src/App/App.csproj
@@ -175,7 +175,7 @@
     <Compile Include="Pages\ScanPage.cs" />
     <Compile Include="Pages\Settings\SettingsCreditsPage.cs" />
     <Compile Include="Pages\Settings\SettingsHelpPage.cs" />
-    <Compile Include="Pages\Settings\SettingsFeaturesPage.cs" />
+    <Compile Include="Pages\Settings\SettingsOptionsPage.cs" />
     <Compile Include="Pages\Settings\SettingsPinPage.cs" />
     <Compile Include="Pages\Lock\LockPinPage.cs" />
     <Compile Include="Pages\MainPage.cs" />
diff --git a/src/App/Pages/Settings/SettingsFeaturesPage.cs b/src/App/Pages/Settings/SettingsOptionsPage.cs
similarity index 99%
rename from src/App/Pages/Settings/SettingsFeaturesPage.cs
rename to src/App/Pages/Settings/SettingsOptionsPage.cs
index 67c1f6b0e..e07c38210 100644
--- a/src/App/Pages/Settings/SettingsFeaturesPage.cs
+++ b/src/App/Pages/Settings/SettingsOptionsPage.cs
@@ -9,13 +9,13 @@ using Bit.App.Utilities;
 
 namespace Bit.App.Pages
 {
-    public class SettingsFeaturesPage : ExtendedContentPage
+    public class SettingsOptionsPage : ExtendedContentPage
     {
         private readonly ISettings _settings;
         private readonly IAppSettingsService _appSettings;
         private readonly IGoogleAnalyticsService _googleAnalyticsService;
 
-        public SettingsFeaturesPage()
+        public SettingsOptionsPage()
         {
             _settings = Resolver.Resolve<ISettings>();
             _appSettings = Resolver.Resolve<IAppSettingsService>();
@@ -231,7 +231,7 @@ namespace Bit.App.Pages
                 ToolbarItems.Add(new DismissModalToolBarItem(this, AppResources.Close));
             }
 
-            Title = AppResources.Features;
+            Title = AppResources.Options;
             Content = scrollView;
         }
 
diff --git a/src/App/Pages/Settings/SettingsPage.cs b/src/App/Pages/Settings/SettingsPage.cs
index 5be0079fe..ad0f4a04a 100644
--- a/src/App/Pages/Settings/SettingsPage.cs
+++ b/src/App/Pages/Settings/SettingsPage.cs
@@ -51,7 +51,7 @@ namespace Bit.App.Pages
         private ExtendedTextCell AboutCell { get; set; }
         private ExtendedTextCell HelpCell { get; set; }
         private ExtendedTextCell RateCell { get; set; }
-        private ExtendedTextCell FeaturesCell { get; set; }
+        private ExtendedTextCell OptionsCell { get; set; }
         private LongDetailViewCell RateCellLong { get; set; }
         private ExtendedTableView Table { get; set; }
 
@@ -143,15 +143,15 @@ namespace Bit.App.Pages
                 ShowDisclousure = true
             };
 
-            FeaturesCell = new ExtendedTextCell
+            OptionsCell = new ExtendedTextCell
             {
-                Text = AppResources.Features,
+                Text = AppResources.Options,
                 ShowDisclousure = true
             };
 
             var otherSection = new TableSection(AppResources.Other)
             {
-                FeaturesCell,
+                OptionsCell,
                 AboutCell,
                 HelpCell
             };
@@ -218,7 +218,7 @@ namespace Bit.App.Pages
             LogOutCell.Tapped += LogOutCell_Tapped;
             AboutCell.Tapped += AboutCell_Tapped;
             HelpCell.Tapped += HelpCell_Tapped;
-            FeaturesCell.Tapped += FeaturesCell_Tapped;
+            OptionsCell.Tapped += OptionsCell_Tapped;
 
             if(RateCellLong != null)
             {
@@ -252,7 +252,7 @@ namespace Bit.App.Pages
             LogOutCell.Tapped -= LogOutCell_Tapped;
             AboutCell.Tapped -= AboutCell_Tapped;
             HelpCell.Tapped -= HelpCell_Tapped;
-            FeaturesCell.Tapped -= FeaturesCell_Tapped;
+            OptionsCell.Tapped -= OptionsCell_Tapped;
 
             if(RateCellLong != null)
             {
@@ -431,9 +431,9 @@ namespace Bit.App.Pages
             }
         }
 
-        private void FeaturesCell_Tapped(object sender, EventArgs e)
+        private void OptionsCell_Tapped(object sender, EventArgs e)
         {
-            Navigation.PushModalAsync(new ExtendedNavigationPage(new SettingsFeaturesPage()));
+            Navigation.PushModalAsync(new ExtendedNavigationPage(new SettingsOptionsPage()));
         }
 
         private void FoldersCell_Tapped(object sender, EventArgs e)
diff --git a/src/App/Resources/AppResources.Designer.cs b/src/App/Resources/AppResources.Designer.cs
index df4aa4dc2..af02c59c9 100644
--- a/src/App/Resources/AppResources.Designer.cs
+++ b/src/App/Resources/AppResources.Designer.cs
@@ -1321,15 +1321,6 @@ namespace Bit.App.Resources {
             }
         }
         
-        /// <summary>
-        ///   Looks up a localized string similar to Features.
-        /// </summary>
-        public static string Features {
-            get {
-                return ResourceManager.GetString("Features", resourceCulture);
-            }
-        }
-        
         /// <summary>
         ///   Looks up a localized string similar to Feature Unavailable.
         /// </summary>
diff --git a/src/App/Resources/AppResources.resx b/src/App/Resources/AppResources.resx
index 8dda401b0..0ebe8f120 100644
--- a/src/App/Resources/AppResources.resx
+++ b/src/App/Resources/AppResources.resx
@@ -818,9 +818,6 @@
   <data name="DisableGADescription" xml:space="preserve">
     <value>We use analytics to better learn how the app is being used so that we can make it better. All data collection is completely anonymous.</value>
   </data>
-  <data name="Features" xml:space="preserve">
-    <value>Features</value>
-  </data>
   <data name="AutofillPasswordField" xml:space="preserve">
     <value>Scan When Password Field Focused</value>
   </data>